You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2015/01/22 17:14:16 UTC

Review Request 30172: Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30172/
-----------------------------------------------------------

Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.


Bugs: AMBARI-9269
    https://issues.apache.org/jira/browse/AMBARI-9269


Repository: ambari


Description
-------

Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2


Diffs
-----

  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py 7d7d20c 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 8593c5a 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/ldap.py 2ff8297 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 8d97c2e 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py 0349c24 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_mapping.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params.py 2ee07d7 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_windows.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py bb54dc8 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py 48c534e 
  ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py 2c99c54 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/gateway-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/gateway-site.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/knox-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/ldap-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/topology.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/users-ldif.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/SLIDER/configurations/slider-client.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/SLIDER/configurations/slider-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/SLIDER/metainfo.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/30172/diff/


Testing
-------

Unix tests passed
Win cluster deployed success


Thanks,

Artem Baranchuk

Re: Review Request 30172: Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30172/#review69829
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On Jan. 22, 2015, 5:03 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30172/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 5:03 p.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-9269
>     https://issues.apache.org/jira/browse/AMBARI-9269
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py 3f30809 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py b93b8e8 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py a24e6ce 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py efa22d4 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/service_mapping.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json 47cd50d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/FLUME/metainfo.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30172/diff/
> 
> 
> Testing
> -------
> 
> Unix tests passed
> Win cluster deployed success
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>

Re: Review Request 30172: Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2

Posted by Artem Baranchuk <ab...@hortonworks.com>.

> On Янв. 27, 2015, 6:37 д.п., Florian Barca wrote:
> > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py, line 26
> > <https://reviews.apache.org/r/30172/diff/2/?file=829925#file829925line26>
> >
> >     Suggest replacing the import * with explicit imports wherever possible

we shouldn't use explicit import for params because we need to import all variable form params_windows. otherwice we will have to list all of them and when we add something new to params_windows it will affect params file to.
we use explicit impotr for the others files


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30172/#review69757
-----------------------------------------------------------


On Янв. 22, 2015, 5:03 п.п., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30172/
> -----------------------------------------------------------
> 
> (Updated Янв. 22, 2015, 5:03 п.п.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-9269
>     https://issues.apache.org/jira/browse/AMBARI-9269
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py 3f30809 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py b93b8e8 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py a24e6ce 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py efa22d4 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/service_mapping.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json 47cd50d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/FLUME/metainfo.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30172/diff/
> 
> 
> Testing
> -------
> 
> Unix tests passed
> Win cluster deployed success
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>

Re: Review Request 30172: Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30172/#review69757
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
<https://reviews.apache.org/r/30172/#comment114568>

    Suggest replacing the import * with explicit imports wherever possible


- Florian Barca


On Jan. 22, 2015, 5:03 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30172/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 5:03 p.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
> 
> 
> Bugs: AMBARI-9269
>     https://issues.apache.org/jira/browse/AMBARI-9269
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py 3f30809 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py b93b8e8 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py a24e6ce 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py efa22d4 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_linux.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/service_mapping.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json 47cd50d 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-conf.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/FLUME/metainfo.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30172/diff/
> 
> 
> Testing
> -------
> 
> Unix tests passed
> Win cluster deployed success
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>

Re: Review Request 30172: Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2

Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30172/
-----------------------------------------------------------

(Updated Янв. 22, 2015, 5:03 п.п.)


Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.


Bugs: AMBARI-9269
    https://issues.apache.org/jira/browse/AMBARI-9269


Repository: ambari


Description
-------

Add FLUME service to HDPWIN 2.1 and HDPWIN 2.2


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py 3f30809 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py b93b8e8 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py a24e6ce 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py efa22d4 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_linux.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/service_mapping.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json 47cd50d 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-conf.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/configuration/flume-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FLUME/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/FLUME/metainfo.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/30172/diff/


Testing
-------

Unix tests passed
Win cluster deployed success


Thanks,

Artem Baranchuk