You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "junichi11 (via GitHub)" <gi...@apache.org> on 2023/03/02 21:57:49 UTC
[GitHub] [netbeans] junichi11 commented on a diff in pull request #5579: Fix #5578 namespaces/use placement
junichi11 commented on code in PR #5579:
URL: https://github.com/apache/netbeans/pull/5579#discussion_r1123766250
##########
php/php.editor/src/org/netbeans/modules/php/editor/actions/FixUsesPerformer.java:
##########
@@ -522,12 +544,29 @@ public List<NamespaceDeclaration> getGlobalNamespaceDeclarations() {
return Collections.unmodifiableList(globalNamespaceDeclarations);
}
+ public List<OffsetRange> getUsedRanges() {
+ return Collections.unmodifiableList(usedRanges);
+ }
+
+ @Override
+ public void visit(UseStatement node) {
+ usedRanges.add(new OffsetRange(node.getStartOffset(), node.getEndOffset()));
Review Comment:
Please add
```java
if (CancelSupport.getDefault().isCancelled()) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists