[GitHub] [drill] cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

[GitBox <gi...@apache.org>]

cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid
URL: https://github.com/apache/drill/pull/1888#issuecomment-593145031
 
 
   @akkapur 
   Thanks for the updates.  I didn't run all the unit tests yet, but I was successfully able to query Druid via Drill and it looks like it is working well!!  The query unit tests that depend on a live installation of Druid worked!   
   
   I ran the following queries without incident:
   
   ```sql
   SHOW DATABASES;
   
   SELECT * FROM druid.wikipedia LIMIT 10;
   
   SELECT user, channel FROM druid.wikipedia LIMIT 10;
   
   SELECT user, channel, bob FROM druid.wikipedia LIMIT 10;
   
   SELECT DISTINCT countryName FROM druid.wikipedia LIMIT 10;
   
   SELECT countryName, COUNT(*) as countryCount 
   FROM druid.wikipedia 
   GROUP BY countryName 
   ORDER BY countryCount DESC;
   
   SELECT countryName, COUNT(*) as countryCount 
   FROM druid.wikipedia 
   WHERE countryName IS NOT NULL 
   GROUP BY countryName 
   ORDER BY countryCount DESC;
   ```
   
   I'll start the code review now but this is looking good!!!  Thank you for your hard work and patience with this PR. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services