[GitHub] Jurrie commented on a change in pull request #2: Implement MRRESOURCES-102

[GitBox <gi...@apache.org>]

Jurrie commented on a change in pull request #2: Implement MRRESOURCES-102
URL: https://github.com/apache/maven-remote-resources-plugin/pull/2#discussion_r235801980
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java
 ##########
 @@ -1336,6 +1341,41 @@ else if ( appendedVmResourceFile.exists() )
         }
     }
 
+    private void copyBundleResource( ClassLoader classLoader, String bundleResource, File to )
+        throws IOException
+    {
+        URL resUrl = classLoader.getResource( bundleResource );
+        if ( resUrl != null )
+        {
+            FileUtils.copyURLToFile( resUrl, to );
+        }
+    }
+
+    private void filterBundleResource( ClassLoader classLoader, String bundleResource, File to )
+        throws IOException, MojoExecutionException
+    {
+        File tmpFile = null;
+        try
+        {
+            tmpFile = File.createTempFile( "maven-remote-resources-plugin", null );
+            tmpFile.deleteOnExit();
 
 Review comment:
   Nice, I didn't realise this! It's fixed in 251f5d3bf6b0290a25d4c7f21e9d2430fdc5837e.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services