[jira] [Commented] (BIGTOP-3269) Add ability to toggle nagios checks in charm

["Kevin Monroe (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965079#comment-16965079 ] 

Kevin Monroe commented on BIGTOP-3269:
--------------------------------------

[~jlosito] BIGTOP-3268 bumped config opts quite a bit (14 new options).  I'd hate to add even more with {{*_check=[True|False]}} options.

What do you think about converting those new {{[warn|crit]}} nagios config opts to strings, and if an operator sets an empty string (or 'false' or 'none' or whatever), that would disable the check? Full disclosure, i don't know nagios checks very well; if you set those opts to '0', does it disable the check? If not, maybe we recommend setting {{[warn|crit}}] to something ridiculous (> 1M) to effectively disable the check.

To summarize, can we use the current min/max checks with 0 or crazy values to effectively disable nagios checks? I'd rather exploit those opts vs introducing new ones.
  

> Add ability to toggle nagios checks in charm
> --------------------------------------------
>
>                 Key: BIGTOP-3269
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-3269
>             Project: Bigtop
>          Issue Type: Improvement
>            Reporter: John Losito
>            Priority: Major
>
> Currently, there isn't a way one can toggle certain nagios checks that the zookeeper charm creates when adding the following relation:
> {code:java}
> juju add-relation zookeeper:local-monitors npre:local-monitors
> {code}
> It would be nice if one could turn off or disable certain checks via the charm's configuration options. For instance, if one wanted to turn off the max latency check, one can do so using the following:
> {code:java}
> juju config zookeeper max_latency_check=false{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)