[GitHub] [james-project] vttranlina commented on a diff in pull request #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...

["vttranlina (via GitHub)" <gi...@apache.org>]

vttranlina commented on code in PR #1689:
URL: https://github.com/apache/james-project/pull/1689#discussion_r1302376117


##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java:
##########
@@ -64,7 +66,12 @@ private CassandraCluster(CassandraModule module, Host host) throws RuntimeExcept
             .keyspace(KEYSPACE)
             .replicationFactor(1)
             .disableDurableWrites();
-        this.nonPrivilegedCluster = ClusterFactory.create(clusterConfiguration, keyspaceConfiguration);
+
+        DriverConfigLoader driverConfigLoader = DriverConfigLoader.programmaticBuilder()
+            .withString(DefaultDriverOption.SESSION_LEAK_THRESHOLD, "16")

Review Comment:
   > Why do we have that many session actives and does it affect perf/stability
   
   I find a test creates a new session for each test and not close to it, I think we have more similarities somewhere 
   
   When I read a log from `test-run.log` of the fail test case, I see a suspect warning
   ```
   
   21:08:37.630 [WARN ] c.d.o.d.i.c.session.DefaultSession - You have too many session instances: 10 active, expected less than 4 (see 'advanced.session-leak.threshold' in the configuration)
   21:08:37.981 [WARN ] c.d.o.d.i.c.session.DefaultSession - You have too many session instances: 11 active, expected less than 4 (see 'advanced.session-leak.threshold' in the configuration)
   ```
    
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org