You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/15 13:43:31 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #189: remove check for old implementation of Akka Discovery
pjfanning opened a new pull request, #189:
URL: https://github.com/apache/incubator-pekko/pull/189
* pekko-discovery will not work directly with any implementation of Akka Discovery.
* we've already messed up this test with a global replace that affects the classname
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #189: remove check for old implementation of Akka Discovery
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #189:
URL: https://github.com/apache/incubator-pekko/pull/189#issuecomment-1431449991
> Looks good to me.
>
> On a somewhat related note, there is an argument that we should implement similar checks in pekko but actually for any akka artifacts that happen to be on the classpath (i.e. to prevent mixing akka and pekko artifacts).
>
> Should I make an issue for this?
Worth tracking an issue but generally, having main Akka libs and Pekko libs on same classpath should be ok. This issue is more about Pekko checking about using an even older Discovery mechanism pre-dating akka-discovery joining the core of Akka.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #189: remove check for old implementation of Akka Discovery
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #189:
URL: https://github.com/apache/incubator-pekko/pull/189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #189: remove check for old implementation of Akka Discovery
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #189:
URL: https://github.com/apache/incubator-pekko/pull/189#issuecomment-1431456995
> > Worth tracking an issue but generally, having main Akka libs and Pekko libs on same classpath should be ok.
>
> Yes but usually it would indicate that you may have done something wrong
Sure - log an issue and it can be discussed. I would prefer to start by logging a warning. But if experience teaches us that having both sets of classes leads to issues, we can make it a failure condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #189: remove check for old implementation of Akka Discovery
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #189:
URL: https://github.com/apache/incubator-pekko/pull/189#issuecomment-1431452593
> Worth tracking an issue but generally, having main Akka libs and Pekko libs on same classpath should be ok.
Yes but usually it would indicate that you may have done something wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org