You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/31 13:58:58 UTC
[GitHub] [camel] klease opened a new pull request #7310: Modify MainHelper.optionKey not to camel case components names in keys.
klease opened a new pull request #7310:
URL: https://github.com/apache/camel/pull/7310
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease commented on pull request #7310: Modify MainHelper.optionKey not to camel case components names in keys.
Posted by GitBox <gi...@apache.org>.
klease commented on pull request #7310:
URL: https://github.com/apache/camel/pull/7310#issuecomment-1084684670
> Ah you need to do this for languages and dataformats also in case they have a dash
Thanks. In fact, now I see all these cases should already be handled in MainHelper.computeProperties() but the property keys have already been transformed in BaseMainSupport.autoConfigurationFromProperties() using optionkey before calling computeProperties.
Maybe that's what should be removed instead. I'll have another look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease edited a comment on pull request #7310: Modify MainHelper.optionKey not to camel case components names in keys.
Posted by GitBox <gi...@apache.org>.
klease edited a comment on pull request #7310:
URL: https://github.com/apache/camel/pull/7310#issuecomment-1084684670
> Ah you need to do this for languages and dataformats also in case they have a dash
Thanks. In fact, now I see all these cases should already be handled in MainHelper.computeProperties() but the property keys have already been transformed in BaseMainSupport.autoConfigurationFromProperties() using optionkey before calling computeProperties.
Maybe that's what should be removed instead. I'll have another look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] klease closed pull request #7310: Modify MainHelper.optionKey not to camel case components names in keys.
Posted by GitBox <gi...@apache.org>.
klease closed pull request #7310:
URL: https://github.com/apache/camel/pull/7310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #7310: Modify MainHelper.optionKey not to camel case components names in keys.
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #7310:
URL: https://github.com/apache/camel/pull/7310#issuecomment-1084636062
Ah you need to do this for languages and dataformats also in case they have a dash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org