[jira] [Commented] (LUCENE-7918) Give access to members of a composite shape

["Karl Wright (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114212#comment-16114212 ] 

Karl Wright commented on LUCENE-7918:
-------------------------------------

Hi [~ivera],
A word of warning: There's a great deal of concern when we add to the public API of anything in Lucene.  This has to be thought out carefully.  The addition of GeoCompositeAreaShape was barely OK, and caused precommit errors that I was scrambling around to fix for seven hours yesterday.

I would therefore like to revisit the public method signature of GeoCompositeAreaShape as part of this request.  The public API for GeoCompositeAreaShape should accept GeoAreaShape for its add method, and the public API for GeoCompositeMembershipShape should accept GeoMembershipShape for its add method.  I strongly suggest that both of these classes be derived from a base class with package scope that has protected methods in it only, and some care is made to keep the public API consistent with the classes that define them.  For example, your getShape() method needs to return GeoAreaShape for GeoCompositeAreaShape, and GeoMembershipShape for GeoCompositeMembershipShape.  Does this make sense?

Finally, the patch has to pass "ant precommit" (runnable only at the topmost level of the Lucene/Solr tree).  Unfortunately due to a bug in one of the checks I cannot run this on my setup so I will need to rely on you to do it before a patch can be committed.

Thanks!!


> Give access to members of a composite shape
> -------------------------------------------
>
>                 Key: LUCENE-7918
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7918
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>
> Hi [~daddywri],
> I hope this is my last point in my wish list. In order to serialize objects I need to access the members of a composite geoshape. This is currently not possible so I was wondering if it is possible to add to more methods to the class GeoCompositeMembershipShape:
> public int size()
> public GeoMembershipShape getShape(int index)
> Thanks,
> Ignacio



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org