[GitHub] thrift issue #1039: THRIFT-2835 Add possibility to distribute generators sep...

[dtmuller <gi...@git.apache.org>]

Github user dtmuller commented on the issue:

    https://github.com/apache/thrift/pull/1039
  
    I added the deployment of headers needed to build plugins. I changed the directory structure to look the same as under /lib (added an extra thrift folder). The reason: for cmake I batch-copied the headers with `install(DIRECTORY ...)` which put them into `/usr/local/include` instead of `/usr/local/include/thrift`. But I changed this back and now copy the files as needed (to exclude unneeded generated headers). Still, I think it's nice to have the dir structure matching the namespaces...
    
    @nsuke If you agree with the header deployment you can pull over my last 5 commits to your original pull-request. If not I can change it back to deploy the headers using the old structure.
    
    The rest looks good to me, I also tested it with my plugin. Only I couldn't get CI test #4 green - though it works locally?!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---