[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #1112: IGNITE-17725 Implement Partition Awareness in Java client

[GitBox <gi...@apache.org>]

ptupitsyn commented on code in PR #1112:
URL: https://github.com/apache/ignite-3/pull/1112#discussion_r977470943


##########
modules/client/src/main/java/org/apache/ignite/internal/client/ReliableChannel.java:
##########
@@ -606,6 +621,21 @@ private void initAllChannelsAsync() {
         );
     }
 
+    private void onTopologyAssignmentChanged(ClientChannel clientChannel) {
+        // NOTE: Multiple channels will send the same update to us, resulting in multiple cache invalidations.
+        // This could be solved with a cluster-wide AssignmentVersion, but we don't have that.

Review Comment:
   That's a great idea! Done. `testClientReceivesPartitionAssignmentUpdates` updated to check heartbeat scenario.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org