You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/26 16:55:29 UTC

[GitHub] [kafka] cmccabe commented on pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

cmccabe commented on pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#issuecomment-848944712


   Thanks for this, @mumrah . Very clean PR overall.
   
   Can you add a test that the RPC fails if we don't have cluster authorization, in `ControllerApisTest.scala`? Should be very similar to `testUnauthorizedHandleAlterPartitionReassignments`. I think it's a good idea to have something like this for all the controller RPCs to prevent authorization regressions.
   
   Also, QuorumControllerTest#testSnapshotSaveAndLoad needs to be updated... it's failing now in the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org