You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "BudhirajaChinmay (via GitHub)" <gi...@apache.org> on 2023/02/20 21:07:59 UTC
[PR] [WIP] Refactor Image Processors (streampipes)
BudhirajaChinmay opened a new pull request, #1331:
URL: https://github.com/apache/streampipes/pull/1331
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
Furthermore, describe potential consequences the changes might have.
-->
Fixes #1330
### Remarks
<!--
Is there anything left we need to pay attention on?
Are there some references that might be important? E.g. links to Confluence, or discussions
on the mailing list or GitHub.
-->
PR introduces (a) breaking change(s): yes
PR introduces (a) deprecation(s): yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Image Processors (streampipes)
Posted by "BudhirajaChinmay (via GitHub)" <gi...@apache.org>.
BudhirajaChinmay commented on PR #1331:
URL: https://github.com/apache/streampipes/pull/1331#issuecomment-1448450760
@tenthe done the refactoring of the file names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Image Processors (streampipes)
Posted by "BudhirajaChinmay (via GitHub)" <gi...@apache.org>.
BudhirajaChinmay commented on PR #1331:
URL: https://github.com/apache/streampipes/pull/1331#issuecomment-1447650718
Fixed the checkstyle errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Image Processors (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti merged PR #1331:
URL: https://github.com/apache/streampipes/pull/1331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Refactor Image Processors (streampipes)
Posted by "BudhirajaChinmay (via GitHub)" <gi...@apache.org>.
BudhirajaChinmay commented on PR #1331:
URL: https://github.com/apache/streampipes/pull/1331#issuecomment-1437917984
@bossenti I thought of keeping the old and new both, using depricated for old processors. Will keep your comment in mind whilst working on it. Thanks for the input :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Refactor Image Processors (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on PR #1331:
URL: https://github.com/apache/streampipes/pull/1331#issuecomment-1437924756
That's a noble aim but this will just result in too many pipeline elements. Furthermore, they don't differ in terms of functionality. It would create a lot of confusion when we have duplicates of all pipeline elements. In short, it would be great if you refrain from it 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Refactor Image Processors (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on PR #1331:
URL: https://github.com/apache/streampipes/pull/1331#issuecomment-1437579865
@BudhirajaChinmay I don't want to disturb you and your PR is still WIP, but I just want to mention shortly that there is no need to duplicate the processors to kee the old and new versions parallely. You can simply refactor the existing ones :) In general, this should not influence the actual behavior of the processing element since it's just a question of structuring the code.
In case that was anyways your plan, I didn't say anything 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Image Processors (streampipes)
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #1331:
URL: https://github.com/apache/streampipes/pull/1331#issuecomment-1447843534
Hey @BudhirajaChinmay,
thanks a lot for the PR 🚀 it looks very good.
I have a small comment, can you please change the suffix of the classes from `Controler` to `Processor`.
This will make it directly clear for other developers that the processor is using the new API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Refactor Image Processors (streampipes)
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on PR #1331:
URL: https://github.com/apache/streampipes/pull/1331#issuecomment-1446942269
Hi @BudhirajaChinmay thanks for your contribution!
The build failed since the `ImagePropertyConstants.java` file doesn't contain an Apache license header. Once this is fixed, the tests should run again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org