You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/06 18:42:48 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10210: feat: Typeahead searchable filter_box for dashboard
codecov-commenter commented on pull request #10210:
URL: https://github.com/apache/incubator-superset/pull/10210#issuecomment-654402976
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10210?src=pr&el=h1) Report
> Merging [#10210](https://codecov.io/gh/apache/incubator-superset/pull/10210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/96647054351535843dc802401a834f64358e99e4&el=desc) will **increase** coverage by `4.45%`.
> The diff coverage is `45.09%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10210 +/- ##
==========================================
+ Coverage 65.69% 70.15% +4.45%
==========================================
Files 594 594
Lines 31497 31668 +171
Branches 3223 3237 +14
==========================================
+ Hits 20692 22216 +1524
+ Misses 10625 9344 -1281
+ Partials 180 108 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.89% <41.17%> (?)` | |
| #javascript | `59.30% <5.88%> (-0.13%)` | :arrow_down: |
| #python | `69.80% <ø> (-0.36%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/visualizations/FilterBox/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC90cmFuc2Zvcm1Qcm9wcy5qcw==) | `78.57% <ø> (+78.57%)` | :arrow_up: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `66.25% <42.55%> (+61.33%)` | :arrow_up: |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `74.07% <66.66%> (-1.40%)` | :arrow_down: |
| [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.35% <0.00%> (-28.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.72% <0.00%> (-12.77%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `78.37% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `92.94% <0.00%> (-3.06%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `83.98% <0.00%> (-2.78%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.83% <0.00%> (-0.84%)` | :arrow_down: |
| ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/10210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10210?src=pr&el=footer). Last update [9664705...811a977](https://codecov.io/gh/apache/incubator-superset/pull/10210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org