You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "2005hithlj (via GitHub)" <gi...@apache.org> on 2024/05/13 04:19:41 UTC

[PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2005hithlj opened a new pull request, #5893:
URL: https://github.com/apache/hbase/pull/5893

   https://issues.apache.org/jira/browse/HBASE-28588


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

Posted by "2005hithlj (via GitHub)" <gi...@apache.org>.

2005hithlj commented on code in PR #5893:
URL: https://github.com/apache/hbase/pull/5893#discussion_r1601555207


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##########
@@ -686,12 +686,6 @@ public void abortCacheFlush(byte[] encodedRegionName) {
     this.sequenceIdAccounting.abortCacheFlush(encodedRegionName);
   }
 
-  @Override
-  public long getEarliestMemStoreSeqNum(byte[] encodedRegionName) {
-    // Used by tests. Deprecated as too subtle for general usage.
-    return this.sequenceIdAccounting.getLowestSequenceId(encodedRegionName);

Review Comment:
   This method is only being called by UTS, and I will attempt to remove those calls.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.

Apache9 commented on code in PR #5893:
URL: https://github.com/apache/hbase/pull/5893#discussion_r1598529826


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##########
@@ -686,12 +686,6 @@ public void abortCacheFlush(byte[] encodedRegionName) {
     this.sequenceIdAccounting.abortCacheFlush(encodedRegionName);
   }
 
-  @Override
-  public long getEarliestMemStoreSeqNum(byte[] encodedRegionName) {
-    // Used by tests. Deprecated as too subtle for general usage.
-    return this.sequenceIdAccounting.getLowestSequenceId(encodedRegionName);

Review Comment:
   Does this method in SequenceIdAccounting still useful?



##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java:
##########
@@ -162,8 +162,8 @@ public void testSelectiveFlushWhenEnabled() throws IOException {
     MemStoreSize cf3MemstoreSize = region.getStore(FAMILY3).getMemStoreSize();
 
     // Get the overall smallest LSN in the region's memstores.
-    long smallestSeqInRegionCurrentMemstore =
-      getWAL(region).getEarliestMemStoreSeqNum(region.getRegionInfo().getEncodedNameAsBytes());
+    long smallestSeqInRegionCurrentMemstore = getWAL(region)
+      .getEarliestMemStoreSeqNum(region.getRegionInfo().getEncodedNameAsBytes(), FAMILY1);

Review Comment:
   Is this the correct way to change the UT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.

Apache9 commented on code in PR #5893:
URL: https://github.com/apache/hbase/pull/5893#discussion_r1604318505


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##########
@@ -686,12 +686,6 @@ public void abortCacheFlush(byte[] encodedRegionName) {
     this.sequenceIdAccounting.abortCacheFlush(encodedRegionName);
   }
 
-  @Override
-  public long getEarliestMemStoreSeqNum(byte[] encodedRegionName) {
-    // Used by tests. Deprecated as too subtle for general usage.
-    return this.sequenceIdAccounting.getLowestSequenceId(encodedRegionName);

Review Comment:
   That's why I say we need to introduce a equivalent version of this method in test code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org