You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/04/19 21:05:47 UTC

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19772


Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................

IMPALA-12077: Remove deprecated Avro methods

Switches Avro methods deprecated in Avro 1.8 to new alternatives.

Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
---
M fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java
M java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/FileMigrator.java
M java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaFlattener.java
M java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaUtil.java
5 files changed, 15 insertions(+), 23 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/19772/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19772

to look at the new patch set (#2).

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................

IMPALA-12077: Remove deprecated Avro methods

Switches Avro methods deprecated in Avro 1.8 to new alternatives.

Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
---
M fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java
M java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/FileMigrator.java
M java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaFlattener.java
M java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaUtil.java
5 files changed, 15 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/19772/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19772 )

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12829/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 16:59:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19772 )

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19772/1/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java
File fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java:

http://gerrit.cloudera.org:8080/#/c/19772/1/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java@112
PS1, Line 112:           createAvroSchema(impalaType), fs.getComment(), Schema.NULL_VALUE);
> This causes test_avro_schema_resolution.py to fail because fields with a nu
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 16:34:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19772 )

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 17:45:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19772 )

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19772/1/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java
File fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java:

http://gerrit.cloudera.org:8080/#/c/19772/1/fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java@112
PS1, Line 112:           createAvroSchema(impalaType), fs.getComment(), null);
This causes test_avro_schema_resolution.py to fail because fields with a null value are omitted. Updating it to Schema.NULL_VALUE looks like it should work.



-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Apr 2023 16:32:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19772 )

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................

IMPALA-12077: Remove deprecated Avro methods

Switches Avro methods deprecated in Avro 1.8 to new alternatives.

Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Reviewed-on: http://gerrit.cloudera.org:8080/19772
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/util/AvroSchemaConverter.java
M fe/src/main/java/org/apache/impala/util/AvroSchemaParser.java
M java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/FileMigrator.java
M java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaFlattener.java
M java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaUtil.java
5 files changed, 15 insertions(+), 23 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19772 )

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 22:53:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19772 )

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12821/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 21:26:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19772 )

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 12:43:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12077: Remove deprecated Avro methods

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19772 )

Change subject: IMPALA-12077: Remove deprecated Avro methods
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9243/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c01886774eb4ca5964a82c2fa568d7c4354c70c
Gerrit-Change-Number: 19772
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 17:45:15 +0000
Gerrit-HasComments: No