[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2261: Introduce RowLayout to represent rows for different purposes

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2261:
URL: https://github.com/apache/arrow-datafusion/pull/2261#discussion_r854534284


##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -136,8 +137,16 @@ async fn explain_analyze_baseline_metrics() {
             }
             let metrics = plan.metrics().unwrap().aggregate_by_partition();
 
-            assert!(metrics.output_rows().unwrap() > 0);
-            assert!(metrics.elapsed_compute().unwrap() > 0);
+            assert!(
+                metrics.output_rows().unwrap() > 0,
+                "plan: {}",
+                DisplayableExecutionPlan::with_metrics(plan).one_line()
+            );
+            assert!(

Review Comment:
   
   
   This change appears to be intermittently failing
   
   https://github.com/apache/arrow-datafusion/runs/6100177086?check_suite_focus=true
   
   https://github.com/apache/arrow-datafusion/runs/6100277301?check_suite_focus=true
   
   https://github.com/apache/arrow-datafusion/runs/6100969854?check_suite_focus=true



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org