[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #19851: [v1.x] ONNX export rewrite Take

[GitBox <gi...@apache.org>]

waytrue17 commented on a change in pull request #19851:
URL: https://github.com/apache/incubator-mxnet/pull/19851#discussion_r571220223



##########
File path: tests/python-pytest/onnx/test_operators.py
##########
@@ -927,3 +927,15 @@ def test_onnx_export_convolution(tmp_path, dtype, shape, num_filter, num_group,
                   **kwargs)
     inputs = [x, w] if no_bias else [x, w, b]
     op_export_test('convolution', M, inputs, tmp_path)
+
+
+@pytest.mark.parametrize('dtype', ['int32', 'int64', 'float16', 'float32', 'float64'])
+@pytest.mark.parametrize('axis', [-3, -2, -1, 0, 1, 2])
+@pytest.mark.parametrize('mode', ['clip', 'wrap'])

Review comment:
       The raise mode will raise an error when indices out of bound. Do you have suggestions how we can test it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org