[jira] [Resolved] (ARTEMIS-5851) When an XA transaction times out on the server side, subsequent client operations are silently auto-committed instead of being rejected

["Timothy A. Bish (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy A. Bish resolved ARTEMIS-5851.
--------------------------------------
    Resolution: Fixed

> When an XA transaction times out on the server side, subsequent client operations are silently auto-committed instead of being rejected
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-5851
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5851
>             Project: Artemis
>          Issue Type: Bug
>          Components: OpenWire
>    Affects Versions: 2.44.0
>            Reporter: Maxim
>            Assignee: Justin Bertram
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.51.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> h3. Sequence of bug:
>  # Client calls {{xa_start(xid)}} — transaction created in {{ResourceManager}}
>  # Server timeout occurs — {{TxTimeoutHandler}} removes transaction from {{ResourceManager}}
>  # Client sends message with original {{transactionId}} (unaware of timeout)
>  # Server's {{lookupTX()}} returns {{null}} (transaction no longer exists)
>  # Message is processed with {{tx = null}} — *auto-committed silently*
>  # Client calls {{xa_end(xid)}} — receives {{XA_RBTIMEOUT}} error
> h3. Root Cause
> In {{OpenWireConnection.java}}, method {{processMessage()}} (lines 1744-1770): 
> {code:java}
> Transaction tx = lookupTX(messageSend.getTransactionId(), session);
> session.getCoreSession().resetTX(tx); // tx = null after timeout
> session.send(producerInfo, messageSend, sendProducerAck); // auto-commit!{code}
> The validation that exists in {{processMessageAck()}} is missing in {{processMessage()}} :
> {code:java}
> // This check exists in processMessageAck() but NOT in processMessage():
> if (ack.getTransactionId() != null && tx == null)
> { throw new IllegalStateException("Transaction not started, " + ack.getTransactionId()); }{code} 
> h3. Proposed Fix
> Add validation to {{processMessage()}}, so when client sends TransactionId, it expects actions inside transaction, not auto-committed actions:
> {code:java}
> Transaction tx = lookupTX(messageSend.getTransactionId(), session);
> if (messageSend.getTransactionId() != null && tx == null)
> { throw new IllegalStateException("Transaction not started or timed out: " + messageSend.getTransactionId()); }
> session.getCoreSession().resetTX(tx);{code} 
> h3. Current bug impact on:
>  * Violates XA transaction atomicity guarantees
>  * Messages silently committed outside of transaction scope
>  * No error reported to client until {{xa_end()}} is called



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org