You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/04 21:07:06 UTC
[GitHub] [tvm] junrushao1994 opened a new pull request #9449: [MetaSchedule] Sample-Perfect-Tile
junrushao1994 opened a new pull request #9449:
URL: https://github.com/apache/tvm/pull/9449
Co-authored-by: Siyuan Feng <Hz...@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32...@users.noreply.github.com>
Co-authored-by: Hongyi Jin <32...@qq.com>
Co-authored-by: Ruihang Lai <la...@qq.com>
Co-authored-by: Wuwei Lin <wu...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
zxybazh commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743273746
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
Thanks for the note. I have carefully checked the implementation. The 3 function calls differ a lot. Let's keep them as they are for conciseness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9449:
URL: https://github.com/apache/tvm/pull/9449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
zxybazh commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743222128
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
Could you please remove this line for me, thanks.
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
Is it possible that we use default argument values to avoid write 3 almost same functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
zxybazh commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743222128
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
Could you please remove this line for me, thanks.
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
Is it possible that we use default argument values to avoid write 3 almost same functions?
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
I mean the `self` param here is not shown in the function call so maybe we can remove it?
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
Thanks for the note. I have carefully checked the implementation. The 3 function calls does differ a lot. Let's keep them as they are for conciseness.
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
Thanks for the note. I have carefully checked the implementation. The 3 function calls differ a lot. Let's keep them as they are for conciseness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743236341
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
These 3 functions serve different purposes and have totally different implementations. If you check the impl, you will see how these 3 functions call each other :-)
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
We don’t need to remove this line. This API is good for internal use
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
oh sure, thanks for spotting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9449:
URL: https://github.com/apache/tvm/pull/9449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743236518
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
We don’t need to remove this line. This API is good for internal use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#issuecomment-961423337
CC @comaniac @zxybazh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
zxybazh commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743273025
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
I mean the `self` param here is not shown in the function call so maybe we can remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743307338
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
oh sure, thanks for spotting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#issuecomment-961471175
@comaniac we would probably need more deliberation in making this decision. As you may see, we have a pretty customized parameter max-innermost-factor which I’m not 100% sure proper for a general implementation. Let’s keep it as it is and add more sampling APIs if we need new functionalities (like power of 2 tile sizes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
zxybazh commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743222128
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
Could you please remove this line for me, thanks.
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
Is it possible that we use default argument values to avoid write 3 almost same functions?
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
I mean the `self` param here is not shown in the function call so maybe we can remove it?
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
Thanks for the note. I have carefully checked the implementation. The 3 function calls does differ a lot. Let's keep them as they are for conciseness.
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
Thanks for the note. I have carefully checked the implementation. The 3 function calls differ a lot. Let's keep them as they are for conciseness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#issuecomment-961423337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743236341
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
These 3 functions serve different purposes and have totally different implementations. If you check the impl, you will see how these 3 functions call each other :-)
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
We don’t need to remove this line. This API is good for internal use
##########
File path: src/tir/schedule/primitive.h
##########
@@ -32,8 +34,8 @@ namespace tir {
* \param max_exclusive The maximum value of the range, exclusive.
* \return The random integer sampled in the given range.
*/
-TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state, int min_inclusive,
- int max_exclusive);
+TVM_DLL int32_t SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
+ int32_t min_inclusive, int32_t max_exclusive);
/*!
* \brief Sample once category from candidates according to the probability weights.
* \param self The schedule to update
Review comment:
oh sure, thanks for spotting this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
zxybazh commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743273746
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
Thanks for the note. I have carefully checked the implementation. The 3 function calls does differ a lot. Let's keep them as they are for conciseness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9449:
URL: https://github.com/apache/tvm/pull/9449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #9449: [MetaSchedule] Sample-Perfect-Tile
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #9449:
URL: https://github.com/apache/tvm/pull/9449#discussion_r743236341
##########
File path: src/tir/schedule/primitive.h
##########
@@ -46,6 +48,40 @@ TVM_DLL int SampleInt(support::LinearCongruentialEngine::TRandState* rand_state,
TVM_DLL int64_t SampleCategorical(support::LinearCongruentialEngine::TRandState* rand_state,
const Array<Integer>& candidates, const Array<FloatImm>& probs,
Optional<Integer>* decision);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_splits);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param extent The loop extent to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ int32_t extent, int32_t n_split, int32_t max_innermost_factor);
+/*!
+ * \brief Sample the factors to perfect tile a specific loop
+ * \param rand_state The random state
+ * \param loop_sref The loop to be tiled
+ * \param n_split The number of tiles to be sampled
+ * \param max_innermost_factor The maximum tile size allowed to be sampled in the innermost loop
+ * \param decision The sampling decision
+ * \return A list of length `n`, the random perfect tile sizes sampled
+ */
+TVM_DLL std::vector<int64_t> SamplePerfectTile(
+ support::LinearCongruentialEngine::TRandState* rand_state, //
+ const tir::StmtSRef& loop_sref, int32_t n_split, int32_t max_innermost_factor,
+ Optional<Array<Integer>>* decision);
Review comment:
These 3 functions serve different purposes and have totally different implementations. If you check the impl, you will see how these 3 functions call each other :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org