You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanju1010 <gi...@git.apache.org> on 2015/08/10 11:36:14 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/671
CLOUDSTACK-8720: Handle corner case in remove nic from vm
Please see the bug for more details
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sanju1010/cloudstack CSBug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/671.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #671
----
commit 41be8f4ef8bc914eb94549003b72387d729a3ef4
Author: sanjeev <sa...@apache.org>
Date: 2015-08-07T12:39:09Z
CLOUDSTACK-8720: Handle corner case in remove nic from vm
Please see the bug for more details
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
Posted by pavanb018 <gi...@git.apache.org>.
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129398162
Looks Good to me.
Probably remove_nic might return an error if the NIC is not removed , but just wondering if a check is needed in the below step , to validate that only 1 NIC exists for the VM by listing nics after the remove nic operation? If you feel the check is redundant then leave it.:
#Try to remove nic 2 from vm1
+ try:
+ vm1.remove_nic(self.apiclient, self.nics[0].id)
+ except Exception as e:
+ self.fail("Failed to delete the nic from vm")
+ return
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
Posted by pavanb018 <gi...@git.apache.org>.
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129720549
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129378007
Test to verify remove nic from vm if the nic ip is same as another vm ip in another network ... === TestName: test_29_remove_nic_CS22503 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 359.186s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129401139
Looks Good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8720: Handle corner case in re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/671
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---