[jira] [Closed] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

["Paul King (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul King closed GROOVY-8834.
-----------------------------
    Resolution: Not A Problem

As per last comment. I'll close this and we can re-open if we have specific improvement suggestions to consider.

> Making "public" - BinaryExpression.leftExpression and similar fields
> --------------------------------------------------------------------
>
>                 Key: GROOVY-8834
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8834
>             Project: Groovy
>          Issue Type: Wish
>            Reporter: Anton Pryamostanov
>            Priority: Major
>              Labels: ast
>
> This is a general request related to AST API.
>  
> Currently BinaryExpression.leftExpression and similar fields are having Private access.
> So to change the value, we need to replace the whole BinaryExpression with new one.
> This is not useful as it requires coding outside of Visitor methods, and I do not see reason why it should be private. It will greatly simplify visitor methods and transformations, if all Expression fields will have Public access.
> Alternatively please add setter methods with Public access.
> List of fields to be changed from Private to Public:
> {code:java}
> ArrayExpression->expressions
> ArrayExpression->sizeExpression
> BitwiseNegationExpression->expression
> BooleanExpression->expression
> CastExpression->expression
> ConstructorCallExpression->arguments
> GStringExpression->strings
> GStringExpression->values
> ListExpression->expressions
> MapExpression->mapEntryExpressions
> MethodPointerExpression->expression
> MethodPointerExpression->methodName
> PropertyExpression->property
> RangeExpression->from
> RangeExpression->to
> SpreadExpression->expression
> SpreadMapExpression->expression
> StaticMethodCallExpression->arguments
> TernaryExpression->booleanExpression
> TernaryExpression->trueExpression
> TernaryExpression->falseExpression
> TupleExpression->expressions
> UnaryMinusExpression->expression
> UnaryPlusExpression->expression{code}
> Note: those fields with "final" modifier should also be made re-assignable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)