[GitHub] [incubator-livy] vanzin commented on a change in pull request #147: [LIVY-563] Merge RSCConf to LivyConf when prepareBuilderProp

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #147: [LIVY-563] Merge RSCConf to LivyConf when prepareBuilderProp
URL: https://github.com/apache/incubator-livy/pull/147#discussion_r264463841
 
 

 ##########
 File path: server/src/main/scala/org/apache/livy/server/interactive/InteractiveSession.scala
 ##########
 @@ -304,6 +304,19 @@ object InteractiveSession extends Logging {
       }
     }
 
+    def mergeRSCConf(): Unit = {
+      val it = livyConf.iterator().asScala
+      while(it.hasNext){
 
 Review comment:
   Space after while (later after `if` too).
   
   But really what you want here is `livyConf.iterator().asScala.foreach { e => ...}`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services