You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/06/17 12:00:58 UTC

[GitHub] [incubator-pekko-http] He-Pin commented on a diff in pull request #184: avoid unapply due to issue reported by Play team (scala 3 only)

He-Pin commented on code in PR #184:
URL: https://github.com/apache/incubator-pekko-http/pull/184#discussion_r1233030451


##########
http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/ProtocolSwitch.scala:
##########
@@ -62,11 +62,12 @@ private[http] object ProtocolSwitch {
               new InHandler {
                 def onPush(): Unit =
                   grab(netIn) match {
-                    case first @ SessionBytes(session, bytes) =>
+                    case first: SessionBytes =>

Review Comment:
   lgtm, fire an issue in dotty too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org