[GitHub] [arrow] ianmcook commented on a change in pull request #10056: ARROW-12184: [R] Bindings for na.fail, na.omit, na.exclude, na.pass

[GitBox <gi...@apache.org>]

ianmcook commented on a change in pull request #10056:
URL: https://github.com/apache/arrow/pull/10056#discussion_r616077571



##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -189,3 +187,109 @@ expect_vector_equal <- function(expr, # A vectorized R expression containing `in
     skip(paste(skip_msg, collpase = "\n"))
   }
 }
+
+expect_vector_equivalent <- function(expr, # A vectorized R expression containing `input` as its input

Review comment:
       I think it's worthwhile to have this new helper function, but it would be better to implement it by adding an optional argument `ignore_attributes = FALSE` to `expect_vector_equal()`, using that to control whether `expect_equivalent()` or `expect_equal()` is used, and then calling that function from this one? That would reduce the amount of copied code.
   
   You'll need to use `!!` to unquote `expr` in the call to  `expect_vector_equivalent()` from here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org