You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/03 14:32:49 UTC
[GitHub] [incubator-inlong] baomingyu opened a new pull request #2881: update dataproy sdk netty version to 4.x
baomingyu opened a new pull request #2881:
URL: https://github.com/apache/incubator-inlong/pull/2881
### Title Name: [INLONG-XYZ][component] Title of the pull request
where *XYZ* should be replaced by the actual issue number.
Fixes #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2881: [INLONG-2880][SDK] Upgrade netty version to 4.x and upgrade log4j to log4j2
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2881:
URL: https://github.com/apache/incubator-inlong/pull/2881#discussion_r818822922
##########
File path: inlong-sdk/dataproxy-sdk/src/main/java/org/apache/inlong/sdk/dataproxy/codec/ProtocolDecoder.java
##########
@@ -18,34 +18,31 @@
package org.apache.inlong.sdk.dataproxy.codec;
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.handler.codec.MessageToMessageDecoder;
import java.nio.charset.StandardCharsets;
-import org.jboss.netty.buffer.ChannelBuffer;
-import org.jboss.netty.channel.Channel;
-import org.jboss.netty.channel.ChannelHandlerContext;
-import org.jboss.netty.channel.DefaultExceptionEvent;
-import org.jboss.netty.handler.codec.frame.FrameDecoder;
+import java.util.List;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class ProtocolDecoder extends FrameDecoder {
+public class ProtocolDecoder extends MessageToMessageDecoder<ByteBuf> {
- private static final Logger logger = LoggerFactory.getLogger(FrameDecoder.class);
+ private static final Logger logger = LoggerFactory.getLogger(ProtocolDecoder.class);
@Override
- protected Object decode(ChannelHandlerContext ctx, Channel channel,
- ChannelBuffer buffer) throws Exception {
- // if(!channel.isConnected()||channel.isReadable()){return null;}
-
+ protected void decode(ChannelHandlerContext var1,
Review comment:
Why named the variable `var1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] baomingyu commented on a change in pull request #2881: [INLONG-2880][SDK] Upgrade netty version to 4.x and upgrade log4j to log4j2
Posted by GitBox <gi...@apache.org>.
baomingyu commented on a change in pull request #2881:
URL: https://github.com/apache/incubator-inlong/pull/2881#discussion_r819199290
##########
File path: inlong-sdk/dataproxy-sdk/src/main/java/org/apache/inlong/sdk/dataproxy/codec/ProtocolDecoder.java
##########
@@ -18,34 +18,31 @@
package org.apache.inlong.sdk.dataproxy.codec;
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.handler.codec.MessageToMessageDecoder;
import java.nio.charset.StandardCharsets;
-import org.jboss.netty.buffer.ChannelBuffer;
-import org.jboss.netty.channel.Channel;
-import org.jboss.netty.channel.ChannelHandlerContext;
-import org.jboss.netty.channel.DefaultExceptionEvent;
-import org.jboss.netty.handler.codec.frame.FrameDecoder;
+import java.util.List;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class ProtocolDecoder extends FrameDecoder {
+public class ProtocolDecoder extends MessageToMessageDecoder<ByteBuf> {
- private static final Logger logger = LoggerFactory.getLogger(FrameDecoder.class);
+ private static final Logger logger = LoggerFactory.getLogger(ProtocolDecoder.class);
@Override
- protected Object decode(ChannelHandlerContext ctx, Channel channel,
- ChannelBuffer buffer) throws Exception {
- // if(!channel.isConnected()||channel.isReadable()){return null;}
-
+ protected void decode(ChannelHandlerContext var1,
Review comment:
Automatically generated, unused variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #2881: [INLONG-2880][SDK] Upgrade netty version to 4.x and upgrade log4j to log4j2
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2881:
URL: https://github.com/apache/incubator-inlong/pull/2881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org