You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Mohammed Nour <no...@gmail.com> on 2006/07/27 16:14:38 UTC
[Patch] - Fix the compilation error because of rev2821 changes
Hi all...
The changes made by rev2821 caused a compilation error, attached the log of
the build and the fix for this error. If it is approved I will open a JIRA
and attach the patch with it.
Thanks and best regards...
Mohammad Nour El-Din
Re: [openejb-dev] [Patch] - Fix the compilation error because of rev2821 changes
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 7/28/06, David Blevins <da...@visi.com> wrote:
> Hmm. Works for me, I'll have to see if I can't find out what may be
> going wrong.
Let's see if that helps:
jlaskowski@dev /cygdrive/c/oss/openejb3
$ svn up
At revision 2824.
jlaskowski@dev /cygdrive/c/oss/openejb3
$ mvn clean install
...
Running org.openejb.RemoteSpringAssemblerTest
02:53:40,906 WARN [OpenEJB] Unable use logging config as there are 3
file references containing directories which have not been created.
See the list below.
02:53:40,906 WARN [OpenEJB] [0]
c:\oss\openejb3\server\openejb-ejbd\target\test-classes\conf\logs\transaction.log
02:53:40,906 WARN [OpenEJB] [1]
c:\oss\openejb3\server\openejb-ejbd\target\test-classes\conf\logs\openejb.log
02:53:40,906 WARN [OpenEJB] [2]
c:\oss\openejb3\server\openejb-ejbd\target\test-classes\conf\logs\server.log
OpenEJB 3.0-SNAPSHOT build: 20060728-0253
http://www.openejb.org
OpenEJB ready.
02:53:41,781 ERROR [OpenEJB] The bean instances business method
encountered a system exception:Testing ability to throw System
Exceptions
java.lang.NullPointerException: Testing ability to throw System Exceptions
at org.openejb.test.stateless.BasicStatelessBean.throwSystemException_NullPointer(BasicStatelessBean.java:67)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.openejb.core.stateless.StatelessContainer._invoke(StatelessContainer.java:145)
at org.openejb.core.stateless.StatelessContainer.invoke(StatelessContainer.java:103)
at org.openejb.server.ejbd.EjbRequestHandler.doEjbObject_BUSINESS_METHOD(EjbRequestHandler.java:175)
at org.openejb.server.ejbd.EjbRequestHandler.processRequest(EjbRequestHandler.java:95)
at org.openejb.server.ejbd.EjbDaemon.processEjbRequest(EjbDaemon.java:134)
at org.openejb.server.ejbd.EjbDaemon.service(EjbDaemon.java:95)
at org.openejb.server.ejbd.EjbDaemon.service(EjbDaemon.java:68)
at org.openejb.server.ejbd.EjbServer.service(EjbServer.java:49)
at org.openejb.server.ServiceDaemon$1.run(ServiceDaemon.java:101)
at java.lang.Thread.run(Thread.java:595)
02:53:42,265 ERROR [OpenEJB] The bean instances business method
encountered a system exception:Testing ability to throw System
Exceptions
java.lang.NullPointerException: Testing ability to throw System Exceptions
at org.openejb.test.stateful.BasicStatefulBean.throwSystemException_NullPointer(BasicStatefulBean.java:79)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.openejb.core.stateful.StatefulContainer.invoke(StatefulContainer.java:166)
at org.openejb.core.stateful.StatefulContainer.invoke(StatefulContainer.java:119)
at org.openejb.server.ejbd.EjbRequestHandler.doEjbObject_BUSINESS_METHOD(EjbRequestHandler.java:175)
at org.openejb.server.ejbd.EjbRequestHandler.processRequest(EjbRequestHandler.java:95)
at org.openejb.server.ejbd.EjbDaemon.processEjbRequest(EjbDaemon.java:134)
at org.openejb.server.ejbd.EjbDaemon.service(EjbDaemon.java:95)
at org.openejb.server.ejbd.EjbDaemon.service(EjbDaemon.java:68)
at org.openejb.server.ejbd.EjbServer.service(EjbServer.java:49)
at org.openejb.server.ServiceDaemon$1.run(ServiceDaemon.java:101)
at java.lang.Thread.run(Thread.java:595)
Tests run: 199, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.75
sec <<< FAILURE!
Running org.openejb.RemoteiTest
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec
Results :
Tests run: 498, Failures: 0, Errors: 1, Skipped: 0
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] There are test failures.
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1 minute 46 seconds
[INFO] Finished at: Fri Jul 28 02:53:43 CEST 2006
[INFO] Final Memory: 20M/254M
[INFO] ------------------------------------------------------------------------
jlaskowski@dev /cygdrive/c/oss/openejb3
$ less server/openejb-ejbd/target/surefire-reports/org.openejb.RemoteSpringAssemblerTest.txt
-------------------------------------------------------------------------------
Test set: org.openejb.RemoteSpringAssemblerTest
-------------------------------------------------------------------------------
Tests run: 199, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.75
sec <<< FAILURE!
org.openejb.test.entity.bmp.BmpTestSuite@148bd9e Time elapsed: 0.016
sec <<< ERROR!
java.sql.SQLException: Cannot create entity table: Unknown Container
Exception; nested exception is:
java.rmi.RemoteException: Cannot read the response from the
server.; nested exception is:
java.io.EOFException
at org.openejb.test.InstantDbTestDatabase.createEntityTable(InstantDbTestDatabase.java:45)
at org.openejb.test.entity.bmp.BmpTestSuite.setUp(BmpTestSuite.java:48)
at org.openejb.test.TestSuite.run(TestSuite.java:24)
at org.openejb.test.TestSuite.run(TestSuite.java:29)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:210)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:135)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:122)
at org.apache.maven.surefire.Surefire.run(Surefire.java:129)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:225)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:747)
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: [openejb-dev] [Patch] - Fix the compilation error because of rev2821 changes
Posted by David Blevins <da...@visi.com>.
On Jul 27, 2006, at 1:19 PM, Jacek Laskowski wrote:
> On 7/27/06, Mohammed Nour <no...@gmail.com> wrote:
>>
>> Hi all...
>>
>> The changes made by rev2821 caused a compilation error, attached
>> the log of
>> the build and the fix for this error. If it is approved I will
>> open a JIRA
>> and attach the patch with it.
[...]
> Thanks Mohammad! I think that before we settle on ASF it's fine to
> send patches to the dev mailing list. After we're in ASF, it won't be
> acceptable, though.
Maybe "not acceptable" is a little strong. Let's say, putting
patches in JIRA is certainly preferred and encouraged :) Certainly,
we're never going to reject anyone's patch cause they sent it to the
list.
> The patch's fixed the compilation issues, but I had to disable the
> tests (maven.test.skip) to build OpenEJB 3. Something's broken yet.
Hmm. Works for me, I'll have to see if I can't find out what may be
going wrong.
-Dave
Re: [openejb-dev] [Patch] - Fix the compilation error because of rev2821 changes
Posted by David Blevins <da...@visi.com>.
On Jul 31, 2006, at 4:00 PM, David Blevins wrote:
>
> On Jul 27, 2006, at 1:19 PM, Jacek Laskowski wrote:
>
>> The patch's fixed the compilation issues, but I had to disable the
>> tests (maven.test.skip) to build OpenEJB 3. Something's broken yet.
>
> On a fully clean build I get compilation errors from this patch:
>
> <snip>
> [INFO] [compiler:testCompile]
> Compiling 15 source files to /Users/dblevins/work/openejb3/
> container/openejb-core/target/test-classes
> [INFO]
> ----------------------------------------------------------------------
> --
> [ERROR] BUILD FAILURE
> [INFO]
> ----------------------------------------------------------------------
> --
> [INFO] Compilation failure
>
> /Users/dblevins/work/openejb3/container/openejb-core/src/test/java/
> org/openejb/core/stateful/StatefulContainerTest.java:[87,64]
> incompatible types
> found :
> java.util.HashMap<java.lang.String,org.openejb.DeploymentInfo>
> required:
> java.util.HashMap<java.lang.String,org.openejb.core.CoreDeploymentInfo
> >
> </snip>
>
> Not sure what the deal is.
My bad. It was a test i hadn't checked in yet :P
-David
> -David
>
>
>
>
>
>
Re: [openejb-dev] [Patch] - Fix the compilation error because of rev2821 changes
Posted by David Blevins <da...@visi.com>.
On Jul 27, 2006, at 1:19 PM, Jacek Laskowski wrote:
> The patch's fixed the compilation issues, but I had to disable the
> tests (maven.test.skip) to build OpenEJB 3. Something's broken yet.
On a fully clean build I get compilation errors from this patch:
<snip>
[INFO] [compiler:testCompile]
Compiling 15 source files to /Users/dblevins/work/openejb3/container/
openejb-core/target/test-classes
[INFO]
------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Compilation failure
/Users/dblevins/work/openejb3/container/openejb-core/src/test/java/
org/openejb/core/stateful/StatefulContainerTest.java:[87,64]
incompatible types
found : java.util.HashMap<java.lang.String,org.openejb.DeploymentInfo>
required:
java.util.HashMap<java.lang.String,org.openejb.core.CoreDeploymentInfo>
</snip>
Not sure what the deal is.
-David
Re: [openejb-dev] [Patch] - Fix the compilation error because of rev2821 changes
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 7/27/06, Mohammed Nour <no...@gmail.com> wrote:
>
> Hi all...
>
> The changes made by rev2821 caused a compilation error, attached the log of
> the build and the fix for this error. If it is approved I will open a JIRA
> and attach the patch with it.
(re-sending to the correct openejb-dev mailing list - please don't use
dev@openejb.codehaus.org any more).
Thanks Mohammad! I think that before we settle on ASF it's fine to
send patches to the dev mailing list. After we're in ASF, it won't be
acceptable, though.
The patch's fixed the compilation issues, but I had to disable the
tests (maven.test.skip) to build OpenEJB 3. Something's broken yet.
Sending container/openejb-core/src/main/java/org/openejb/assembler/classic/ContainerBuilder.java
Sending container/openejb-core/src/main/java/org/openejb/assembler/classic/EjbJarBuilder.java
Sending container/openejb-core/src/main/java/org/openejb/assembler/spring/DeploymentsFactory.java
Sending container/openejb-core/src/test/java/org/openejb/core/stateless/StatelessContainerTest.java
Transmitting file data ....
Committed revision 2824.
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: [openejb-dev] [Patch] - Fix the compilation error because of rev2821 changes
Posted by Mohammed Nour <no...@gmail.com>.
Hi all...
Hi David, thanks for the advice, but someone before has opened a JIRA
because build error - actually it was his mistake -, and the team advised
him not to rush in opening unnecessary ones, so I didn't want to embarrass
myself and be in the same situation :). that's all.
Thanks and best regards...
Mohammad Nour El-Din
On 7/29/06, David Blevins <da...@visi.com> wrote:
>
> On Jul 28, 2006, at 10:01 AM, Mohammed Nour wrote:
>
> > Sorry for this but I preferred not to open a JIRA until after the
> > team approve what I claim, as I explained in my mail. And until now
> > I did know whether to open a JIRA and attach the patch with it or
> > not :).
>
> Nothing wrong with being considerate -- that's a good quality :)
> Just don't forget you are part of the team too, so you can file JIRAs
> any time you like!
>
> -David
>
>
>
>
Re: [openejb-dev] [Patch] - Fix the compilation error because of rev2821 changes
Posted by David Blevins <da...@visi.com>.
On Jul 28, 2006, at 10:01 AM, Mohammed Nour wrote:
> Sorry for this but I preferred not to open a JIRA until after the
> team approve what I claim, as I explained in my mail. And until now
> I did know whether to open a JIRA and attach the patch with it or
> not :).
Nothing wrong with being considerate -- that's a good quality :)
Just don't forget you are part of the team too, so you can file JIRAs
any time you like!
-David