You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/31 10:46:00 UTC

[jira] [Work logged] (HIVE-26274) No vectorization if query has upper case window function

     [ https://issues.apache.org/jira/browse/HIVE-26274?focusedWorklogId=776228&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776228 ]

ASF GitHub Bot logged work on HIVE-26274:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/May/22 10:45
            Start Date: 31/May/22 10:45
    Worklog Time Spent: 10m 
      Work Description: kasakrisz opened a new pull request, #3332:
URL: https://github.com/apache/hive/pull/3332

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   Convert window function names to lower case when looking up in vectorizable function registry.
   
   ### Why are the changes needed?
   Support case insensitivity of window functions when vectorizing PTF operator.
   
   ### Does this PR introduce _any_ user-facing change?
   No, but explain vectorization output may change if query has window functions
   
   ### How was this patch tested?
   ```
   mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=vector_ptf_1.q -pl itests/qtest -Pitests
   ```




Issue Time Tracking
-------------------

            Worklog Id:     (was: 776228)
    Remaining Estimate: 0h
            Time Spent: 10m

> No vectorization if query has upper case window function
> --------------------------------------------------------
>
>                 Key: HIVE-26274
>                 URL: https://issues.apache.org/jira/browse/HIVE-26274
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code}
> CREATE TABLE t1 (a int, b int);
> EXPLAIN VECTORIZATION ONLY SELECT ROW_NUMBER() OVER(order by a) AS rn FROM t1;
> {code}
> {code}
> PLAN VECTORIZATION:
>   enabled: true
>   enabledConditionsMet: [hive.vectorized.execution.enabled IS true]
> STAGE DEPENDENCIES:
>   Stage-1 is a root stage
>   Stage-0 depends on stages: Stage-1
> STAGE PLANS:
>   Stage: Stage-1
>     Tez
>       Edges:
>         Reducer 2 <- Map 1 (SIMPLE_EDGE)
>       Vertices:
>         Map 1 
>             Execution mode: vectorized, llap
>             LLAP IO: all inputs
>             Map Vectorization:
>                 enabled: true
>                 enabledConditionsMet: hive.vectorized.use.vector.serde.deserialize IS true
>                 inputFormatFeatureSupport: [DECIMAL_64]
>                 featureSupportInUse: [DECIMAL_64]
>                 inputFileFormats: org.apache.hadoop.mapred.TextInputFormat
>                 allNative: true
>                 usesVectorUDFAdaptor: false
>                 vectorized: true
>         Reducer 2 
>             Execution mode: llap
>             Reduce Vectorization:
>                 enabled: true
>                 enableConditionsMet: hive.vectorized.execution.reduce.enabled IS true, hive.execution.engine tez IN [tez] IS true
>                 notVectorizedReason: PTF operator: ROW_NUMBER not in supported functions [avg, count, dense_rank, first_value, lag, last_value, lead, max, min, rank, row_number, sum]
>                 vectorized: false
>   Stage: Stage-0
>     Fetch Operator
> {code}
> {code}
>                 notVectorizedReason: PTF operator: ROW_NUMBER not in supported functions [avg, count, dense_rank, first_value, lag, last_value, lead, max, min, rank, row_number, sum]
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)