You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/20 23:51:51 UTC
[GitHub] [superset] codyml opened a new pull request, #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
codyml opened a new pull request, #21897:
URL: https://github.com/apache/superset/pull/21897
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR removes the `DRILL_TO_DETAIL` feature flag, as this feature is no longer in development.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before (w/o feature flag):
<img width="899" alt="Screen Shot 2022-10-20 at 5 45 34 PM" src="https://user-images.githubusercontent.com/13007381/197079981-357b0a12-7385-4b54-95a2-04606baa1758.png">
After (w/o feature flag):
<img width="901" alt="Screen Shot 2022-10-20 at 5 42 12 PM" src="https://user-images.githubusercontent.com/13007381/197079986-4b4fdaf3-cf91-4d06-9d32-2b266e2bfd48.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Without the feature flag on, make sure the Drill to Detail contextual menu and chart header dropdown menus appear on dashboards.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml closed pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
codyml closed pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
URL: https://github.com/apache/superset/pull/21897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1290966875
/testenv up FEATURE_DRILL_TO_DETAIL=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1325742959
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1290963203
@kasiazjc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1325742622
Closing as we're actually going to leave the FFs in for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1292417318
Thanks @kasiazjc, was able to reproduce these issues and @michael-s-molina that makes sense about the table element. Since these don't sound blocking let's try to fix them in future PRs, and @jinghua-qa feel free to go ahead with QA testing on this PR as-is. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1301522176
I found some issue:
1, drill to details by is block by the tooltip when chart width is small
step 1, go to slack dashboard
step 2, right click for Weekly Threads on date
Expected results
user can open drill to details by
Actual results
drill to details by is block by the tool tip
https://user-images.githubusercontent.com/81597121/199626216-d011bc34-5267-4b5d-84ad-0f59ac2e7d87.mov
2, Drill to details by time dimension show filter error in time series bar chart
step 1, go to video games sales dashboard
step 2, right click on a data in the Rise & Fall of Video Game Consoles time series area chart in a line
step 3, open drill to details by {time dimension}
Expected results
show data table with {time dimension}
Actual results
show filter error
https://user-images.githubusercontent.com/81597121/199626543-fc0b7ab1-4aca-474e-9608-786979dc5307.mov
3, [D2D] pivot table drill to details by time dimension return no row
Repro steps
step 1, go to birth name dashboard and open Pivot Table v2
step 2, in explore, change the row to be time column ds
step 3, save the chart in dashboard
step 4, open drill to details by time dimension in dashboard
Expected results
open data details with time dimension
Actual results
return no row
https://user-images.githubusercontent.com/81597121/199626656-ffc4fa90-0221-44bb-8634-a0d37492f37b.mov
4, drill to details by country return no row for world map
Repro steps
step 1, go to world bank's data dashboard
step 2, go to china and right click, open drill to details by china
Expected results
open detail data with clearable filter china
Actual results
return no row
<img width="1792" alt="Screen Shot 2022-11-02 at 5 33 18 PM" src="https://user-images.githubusercontent.com/81597121/199627120-20b38477-99e4-45f0-8577-3ff51d75e3b8.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1307861273
@michael-s-molina Ephemeral environment spinning up at http://34.209.74.129:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1307855511
/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DRILL_TO_DETAIL=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1286289438
# [Codecov](https://codecov.io/gh/apache/superset/pull/21897?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21897](https://codecov.io/gh/apache/superset/pull/21897?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6753000) into [master](https://codecov.io/gh/apache/superset/commit/9a063abb3b28e32b1107950942571d564bb283f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a063ab) will **decrease** coverage by `0.17%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #21897 +/- ##
==========================================
- Coverage 55.55% 55.38% -0.18%
==========================================
Files 1806 1806
Lines 69140 69140
Branches 7393 7393
==========================================
- Hits 38409 38291 -118
- Misses 28822 28940 +118
Partials 1909 1909
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| presto | `52.82% <ø> (ø)` | |
| python | `57.59% <ø> (-0.36%)` | :arrow_down: |
| unit | `51.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [...frontend/src/components/Chart/ChartContextMenu.tsx](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvQ2hhcnRDb250ZXh0TWVudS50c3g=) | `11.53% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.05% <ø> (ø)` | |
| [...et-frontend/src/components/Chart/ChartRenderer.jsx](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvQ2hhcnRSZW5kZXJlci5qc3g=) | `51.25% <100.00%> (ø)` | |
| [...dashboard/components/SliceHeaderControls/index.tsx](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXgudHN4) | `70.21% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.19%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `34.38% <0.00%> (-30.44%)` | :arrow_down: |
| [superset/connectors/sqla/utils.py](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3V0aWxzLnB5) | `77.45% <0.00%> (-2.95%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `77.03% <0.00%> (-2.23%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `74.96% <0.00%> (-1.11%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/superset/pull/21897/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1291223626
@michael-s-molina Ephemeral environment spinning up at http://34.222.230.87:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1292151152
thanks for the env @michael-s-molina 🙏
I found a few things to check/fix:
- there is gray overlay under the modal missing (that we do for example for visualization modal in Explore) - I only just noticed that it is also the case for view as a table, can we add it? Dashboard is pretty overwhelming and because of that it's hard to focus on the modal
- in the table, when I scroll down on one page, and go to the next one the scroll position is retained - it should go to the top instead
- in the table, when I go to another page, for a few seconds I cannot scroll it as it’s frozen and the scroll bar on the right does not show up, after a few seconds it starts working again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1292182235
> in the table, when I go to another page, for a few seconds I cannot scroll it as it’s frozen and the scroll bar on the right does not show up, after a few seconds it starts working again
This one might be tricky. I think this is caused by tables with many columns which would require horizontal virtualization. If that's the case, then we'll be able to fix it in the future with the work @eric-briscoe is doing with the table component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #21897: chore(dashboard): Remove DRILL_TO_DETAIL feature flag
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #21897:
URL: https://github.com/apache/superset/pull/21897#issuecomment-1302181682
@jinghua-qa Thanks so much, will look into these ASAP!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org