You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2026/05/15 07:10:14 UTC
[Impala-ASF-CR] IMPALA-14992: Deflake test cancelled nodes in exec summary
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24306
Change subject: IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
......................................................................
IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
The failed query has 3 scan nodes:
with l as (
select * from tpch.lineitem UNION ALL select * from tpch.lineitem
)
select STRAIGHT_JOIN count(*) from
(select * from tpch.lineitem a LIMIT 1) a
join
(select * from l LIMIT 125000) b
on a.l_orderkey = -b.l_orderkey;
The test expects the two scan nodes under UNION have the CANCELLED
marker and the other scan node on "tpch.lineitem a LIMIT 1" can complete
so won't have the CANCELLED marker. However, "LIMIT 1" is also applied
to the ExchangeNode on top of that scan, and the ExchangeNode is the
leaf of the coordinator fragment:
F01:PLAN FRAGMENT [UNPARTITIONED] hosts=1 instances=1
...
06:EXCHANGE [UNPARTITIONED]
| limit: 1
| in pipelines: 00(GETNEXT)
|
F00:PLAN FRAGMENT [RANDOM] hosts=3 instances=3
00:SCAN HDFS [tpch.lineitem a, RANDOM]
HDFS partitions=1/1 files=1 size=718.94MB
...
limit: 1
There are 3 scan node instances for this HdfsScanNode. Any of them
returns a row leads the coordinator to mark the query as finished and
cancels all running fragment instances, which might cancel the other 2
scan node instances. Usually they finish quickly since they have limit=1
so won't be cancelled. The test is flaky when the cluster is busy so
those scan node instances run slow.
This patch deflakes the test by not using "LIMIT 1" on the scan to
ensure it can finish.
Testing
- Ran the test 1000 times.
Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
---
M tests/query_test/test_observability.py
1 file changed, 18 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/24306/1
--
To view, visit http://gerrit.cloudera.org:8080/24306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
Gerrit-Change-Number: 24306
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-14992: Deflake test cancelled nodes in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24306 )
Change subject: IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13499/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
Gerrit-Change-Number: 24306
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2026 07:53:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14992: Deflake test cancelled nodes in exec summary
Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24306 )
Change subject: IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
Gerrit-Change-Number: 24306
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2026 09:52:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14992: Deflake test cancelled nodes in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24306 )
Change subject: IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
......................................................................
IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
The failed query has 3 scan nodes:
with l as (
select * from tpch.lineitem UNION ALL select * from tpch.lineitem
)
select STRAIGHT_JOIN count(*) from
(select * from tpch.lineitem a LIMIT 1) a
join
(select * from l LIMIT 125000) b
on a.l_orderkey = -b.l_orderkey;
The test expects the two scan nodes under UNION have the CANCELLED
marker and the other scan node on "tpch.lineitem a LIMIT 1" can complete
so won't have the CANCELLED marker. However, "LIMIT 1" is also applied
to the ExchangeNode on top of that scan, and the ExchangeNode is the
leaf of the coordinator fragment:
F01:PLAN FRAGMENT [UNPARTITIONED] hosts=1 instances=1
...
06:EXCHANGE [UNPARTITIONED]
| limit: 1
| in pipelines: 00(GETNEXT)
|
F00:PLAN FRAGMENT [RANDOM] hosts=3 instances=3
00:SCAN HDFS [tpch.lineitem a, RANDOM]
HDFS partitions=1/1 files=1 size=718.94MB
...
limit: 1
There are 3 scan node instances for this HdfsScanNode. Any of them
returns a row leads the coordinator to mark the query as finished and
cancels all running fragment instances, which might cancel the other 2
scan node instances. Usually they finish quickly since they have limit=1
so won't be cancelled. The test is flaky when the cluster is busy so
those scan node instances run slow.
This patch deflakes the test by not using "LIMIT 1" on the scan to
ensure it can finish.
Testing
- Ran the test 1000 times.
Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
Reviewed-on: http://gerrit.cloudera.org:8080/24306
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Surya Hebbar <sh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_observability.py
1 file changed, 18 insertions(+), 15 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
Surya Hebbar: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/24306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
Gerrit-Change-Number: 24306
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14992: Deflake test cancelled nodes in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24306 )
Change subject: IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
Gerrit-Change-Number: 24306
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2026 07:53:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14992: Deflake test cancelled nodes in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24306 )
Change subject: IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22444/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
Gerrit-Change-Number: 24306
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2026 07:34:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14992: Deflake test cancelled nodes in exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24306 )
Change subject: IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
Gerrit-Change-Number: 24306
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2026 12:24:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14992: Deflake test cancelled nodes in exec summary
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24306 )
Change subject: IMPALA-14992: Deflake test_cancelled_nodes_in_exec_summary
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing it so quickly!
--
To view, visit http://gerrit.cloudera.org:8080/24306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00d0b81051c864f76060ae7ebcafb635da37ab1e
Gerrit-Change-Number: 24306
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2026 07:44:20 +0000
Gerrit-HasComments: No