You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2023/09/26 22:40:02 UTC
[GitHub] [spark] ueshin opened a new pull request, #43137: [SPARK-43662][PS][CONNECT] Support merge_asof in Spark Connect
ueshin opened a new pull request, #43137:
URL: https://github.com/apache/spark/pull/43137
### What changes were proposed in this pull request?
Supports `merge_asof` in Spark Connect.
### Why are the changes needed?
`merge_asof` is missing in Spark Connect.
Ref: https://spark.apache.org/docs/latest/api/python/reference/pyspark.pandas/api/pyspark.pandas.merge_asof.html
### Does this PR introduce _any_ user-facing change?
Yes, `merge_asof` is available in Spark Connect.
### How was this patch tested?
The parity tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #43137: [SPARK-43662][PS][CONNECT] Support merge_asof in Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #43137:
URL: https://github.com/apache/spark/pull/43137#issuecomment-1736829982
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a diff in pull request #43137: [SPARK-43662][PS][CONNECT] Support merge_asof in Spark Connect
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on code in PR #43137:
URL: https://github.com/apache/spark/pull/43137#discussion_r1337896004
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -595,6 +595,47 @@ def join(
join.__doc__ = PySparkDataFrame.join.__doc__
+ def _joinAsOf(
Review Comment:
Because so far this is not public for PySpark's DataFrame, but supposed to be called from pandas API's `merge_asof` only.
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -595,6 +595,47 @@ def join(
join.__doc__ = PySparkDataFrame.join.__doc__
+ def _joinAsOf(
Review Comment:
Because so far this is not public for PySpark's DataFrame, but supposed to be called from pandas API's `merge_asof` only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #43137: [SPARK-43662][PS][CONNECT] Support merge_asof in Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #43137: [SPARK-43662][PS][CONNECT] Support merge_asof in Spark Connect
URL: https://github.com/apache/spark/pull/43137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on pull request #43137: [SPARK-43662][PS][CONNECT] Support merge_asof in Spark Connect
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #43137:
URL: https://github.com/apache/spark/pull/43137#issuecomment-1736399663
cc @itholic @HyukjinKwon @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #43137: [SPARK-43662][PS][CONNECT] Support merge_asof in Spark Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #43137:
URL: https://github.com/apache/spark/pull/43137#discussion_r1337893291
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -595,6 +595,47 @@ def join(
join.__doc__ = PySparkDataFrame.join.__doc__
+ def _joinAsOf(
Review Comment:
I have a dumb question: why this method name start with `_`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org