You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/01 18:07:26 UTC

[GitHub] [beam] tvalentyn commented on a diff in pull request #17538: [BEAM-13769]Add no_xdist marker for cloudpickle test

tvalentyn commented on code in PR #17538:
URL: https://github.com/apache/beam/pull/17538#discussion_r887156662


##########
sdks/python/apache_beam/runners/portability/stager_test.py:
##########
@@ -242,7 +242,7 @@ def test_with_main_session(self):
 
   # (BEAM-13769): Remove the decorator once cloudpickle is default pickle
   # library
-  @pytest.mark.skip
+  @pytest.mark.no_xdist

Review Comment:
   the important point is to reset the pickler *after* the test, not before the test, so as to avoid side-effects on other tests. so you'd need to put it in tearDown



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org