[GitHub] [dubbo-go] zouyx commented on a change in pull request #545: Add comments for config_center

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #545:
URL: https://github.com/apache/dubbo-go/pull/545#discussion_r432377649



##########
File path: config_center/apollo/listener.go
##########
@@ -49,15 +49,15 @@ func (a *apolloListener) OnChange(changeEvent *agollo.ChangeEvent) {
 	}
 }
 
-// AddListener ...
+// AddListener add a listener for apollo

Review comment:
       ```suggestion
   // AddListener adds a listener for apollo
   ```

##########
File path: config_center/apollo/listener.go
##########
@@ -29,7 +29,7 @@ type apolloListener struct {
 	listeners map[config_center.ConfigurationListener]struct{}
 }
 
-// NewApolloListener ...
+// NewApolloListener new an apolloListener

Review comment:
       ```suggestion
   // NewApolloListener makes an new  apolloListener
   ```

##########
File path: config_center/apollo/listener.go
##########
@@ -49,15 +49,15 @@ func (a *apolloListener) OnChange(changeEvent *agollo.ChangeEvent) {
 	}
 }
 
-// AddListener ...
+// AddListener add a listener for apollo
 func (a *apolloListener) AddListener(l config_center.ConfigurationListener) {
 	if _, ok := a.listeners[l]; !ok {
 		a.listeners[l] = struct{}{}
 		agollo.AddChangeListener(a)
 	}
 }
 
-// RemoveListener ...
+// RemoveListener remove listeners of apollo

Review comment:
       ```suggestion
   // RemoveListener removes listeners of apollo
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org