You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by riknoll <gi...@git.apache.org> on 2016/03/14 20:23:20 UTC
[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/18
CB-10866: Adding engine info to package.json
Putting the version constraint at 0.0.0 because the whitelist used to be part of the platform
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/riknoll/cordova-plugin-whitelist CB-10866
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-whitelist/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 51021a6c90048ab4e83a91ad32f4a9b447ea5ab9
Author: Richard Knoll <ri...@gmail.com>
Date: 2016-03-14T19:20:24Z
CB-10866: Adding engine info to package.json
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-219856568
This isn't a regression, and this PR has been open for quite a while so I'm going to merge this. That being said, I will create a JIRA because we can maybe do something like support `cordovaDependencies` being a top level object instead of in "engines".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-219847832
@stewshka the `cordovaDependencies` object is used by Cordova, not npm, so it isn't really covered in the npm docs. You can find our documentation on it here: http://cordova.apache.org/docs/en/latest/guide/hybrid/plugins/index.html#specifying-cordova-dependencies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: CB-10866: Adding engine inf...
Posted by stewshka <gi...@git.apache.org>.
Github user stewshka commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/18#issuecomment-218947372
My visual studio complains that the "engines" item must have an object as its value.
But when I paste your code, i get a complain that the "cordovaDependencies" file must have a string as its value.
woudnt this be the solution?
```
"engines": {
"cordova-android": ">=4.0.0"
},
```
Documentation: https://docs.npmjs.com/files/package.json#engines
Please fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org