[GitHub] [samza] Sanil15 commented on a change in pull request #1487: SAMZA-2644: ContainerLaunchUtil swallows exception and does not even log them if an exception occurs while setting up a Samza container or invoking run on it

[GitBox <gi...@apache.org>]

Sanil15 commented on a change in pull request #1487:
URL: https://github.com/apache/samza/pull/1487#discussion_r604444879



##########
File path: samza-core/src/main/java/org/apache/samza/runtime/ContainerLaunchUtil.java
##########
@@ -174,6 +174,8 @@ private static void run(
         log.error("Container stopped with Exception. Exiting process now.", containerRunnerException);
         System.exit(1);
       }
+    } catch (Throwable e) {
+      log.error("Container stopped with Exception. ", containerRunnerException);

Review comment:
       that is for heartbeat monitor, that exit defines a self kill when container cannot reach to am, the orphan case




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org