You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/17 07:34:14 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #636: Add `required` job in kvrocks CI for `required_status_checks` configuration

PragmaTwice commented on code in PR #636:
URL: https://github.com/apache/incubator-kvrocks/pull/636#discussion_r899845944


##########
.asf.yaml:
##########
@@ -31,6 +31,10 @@ github:
       required_pull_request_reviews:
         dismiss_stale_reviews: false
         required_approving_review_count: 1
+      required_status_checks:
+        strict: true
+        contexts:
+          - "kvrocks ci actions / required (pull_request)"

Review Comment:
   done



##########
.github/workflows/kvrocks.yaml:
##########
@@ -96,3 +96,9 @@ jobs:
           cd build
           cmake ..
           make -j4
+
+  required:
+    runs-on: ubuntu-latest
+    needs: [lint-build-test-on-ubuntu, build-on-macos-latest]
+    steps:
+      - run: echo success

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org