You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2022/09/06 15:27:59 UTC

[GitHub] [isis] andi-huber commented on a diff in pull request #1086: ISIS-3204: Metamodel Support for Bounded Generics

andi-huber commented on code in PR #1086:
URL: https://github.com/apache/isis/pull/1086#discussion_r963851867


##########
core/config/src/main/java/org/apache/isis/core/config/progmodel/ProgrammingModelConstants.java:
##########
@@ -577,6 +624,50 @@ public static Optional<CollectionType> valueOf(final @Nullable Class<?> type) {
                         .filter(collType->collType.getContainerType().isAssignableFrom(type))
                         .findFirst();
         }
+        public Object unmodifiableCopyOf(
+                final Class<?> elementType, final @NonNull Iterable<?> nonScalar) {
+            // defensive copy
+            return asContainerType(elementType,
+                    _NullSafe.stream(nonScalar).collect(Collectors.toList()));
+        }
+        protected abstract Object asContainerType(
+                final Class<?> elementType, final @NonNull List<?> nonScalar);
+
+        /*{

Review Comment:
   remove comment block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org