You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ryan Ordway <ry...@nwgeeks.com> on 2003/10/28 00:51:02 UTC

problem with svn:keywords and binary files

	It seems that svn propset svn:keywords don't care what type of
file the target file is. If you include the $Id$ keyword and, for example,
a Word document contains that keyword the file is destroyed when svn tries
to replace it with the Id string. Should svn determine whether or not to
honor svn:keywords, or invoker beware?

	I couldn't find this anywhere in the issue tracker, hopefully this
is the right place to bring this up.

	Thanks,

	Ryan

-- 
ryan@nwgeeks.com
HELO... my name is root... you have SIGKILLed my father... prepare to vi!

     Hi! Can you to speak to me the learn for to speak the Unix?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: problem with svn:keywords and binary files

Posted by "B. W. Fitzpatrick" <fi...@red-bean.com>.
Ryan Ordway <ry...@nwgeeks.com> writes:
> 
> 	It seems that svn propset svn:keywords don't care what type of
> file the target file is. If you include the $Id$ keyword and, for example,
> a Word document contains that keyword the file is destroyed when svn tries
> to replace it with the Id string. Should svn determine whether or not to
> honor svn:keywords, or invoker beware?

Maybe we should document the danger further in the book, but svn already
does The Right Thing--it doesn't expand keywords by default.  You have
to turn keyword expansion on, and only then does Subversion expand
keywords.

So, to answer your question, I would say that it behaves correctly as
is, but could probably use a little more documentation about the dangers
of turning on keyword expansion on non-text files.  There are plenty of
ways that you can use Subversion (or just about any software for that
matter) to shoot yourself in the foot--this is just one of them. :)
 
> 	I couldn't find this anywhere in the issue tracker, hopefully this
> is the right place to bring this up.

This is a fine place.  users@subversion.tigris.org may be more
appropriate, but I dunno.

-Fitz

--
Brian W. Fitzpatrick    <fi...@red-bean.com>   http://www.red-bean.com/fitz/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org