You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/02 18:53:15 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #1698: Docs: Clean up installation requirements and only support pipenv
btashton opened a new pull request #1698:
URL: https://github.com/apache/incubator-nuttx/pull/1698
## Summary
Instead of supporting both pipenv and requirements.txt we just support pipenv and then generate the requirements.txt file needed on the fly for the CI system.
Also we were pinning the version of python to 3.7 I **really** do not want to do that (my system is 3.8 for example), we are not doing anything special here long as they are using a modern version of Python 3 everything will be fine. I would have liked to specify 3.6 as the min version, but pipenv explicitly does not support this. So I just changed it to be 3
I also moved the pyenv docs to just point to at the project, we do not need to copy them. Most people unless they are on MacOS do not bother with using it.
The markers are also not needed in the lock file. I am actually not quite sure why those were being generated in the first place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1698: Docs: Clean up installation requirements and only support pipenv
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on pull request #1698:
URL: https://github.com/apache/incubator-nuttx/pull/1698#issuecomment-685952297
@btashton Thanks for doing this. Yes, pinning to Python 3 rather than a specific point revision is the right thing to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d merged pull request #1698: Docs: Clean up installation requirements and only support pipenv
Posted by GitBox <gi...@apache.org>.
v01d merged pull request #1698:
URL: https://github.com/apache/incubator-nuttx/pull/1698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1698: Docs: Clean up installation requirements and only support pipenv
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1698:
URL: https://github.com/apache/incubator-nuttx/pull/1698#issuecomment-685939441
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org