[GitHub] [accumulo] brianloss commented on a diff in pull request #3093: Hide Thrift generated files on GitHub diff, docker build

[GitBox <gi...@apache.org>]

brianloss commented on code in PR #3093:
URL: https://github.com/apache/accumulo/pull/3093#discussion_r1030382069


##########
contrib/build.sh:
##########
@@ -0,0 +1,40 @@
+#! /bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+VERSION="1"
+IMAGE="accumulo-build-environment-${VERSION}"

Review Comment:
   Could this not be built and published to GH packages? I guess in that case you couldn't set the uid/gid to match, but you could still build/publish a base image. Then have the script extend that base image and only define a user matching the uid/gid of the local user. Having a published base image would allow you to use the image for things like GH actions and/or codespaces. It would also speed up the local build for most people since they'd only have to download the base image vs wait for thrift to build while building the image. The base image itself could be built and published using GH actions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org