[jira] [Resolved] (YARN-11998) Resolve SpotBugs nullness warning in PublicLocalizer.run()

["Shilun Fan (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-11998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shilun Fan resolved YARN-11998.
-------------------------------
    Fix Version/s: 3.5.1
                   3.6.0
     Hadoop Flags: Reviewed
       Resolution: Fixed

> Resolve SpotBugs nullness warning in PublicLocalizer.run()
> ----------------------------------------------------------
>
>                 Key: YARN-11998
>                 URL: https://issues.apache.org/jira/browse/YARN-11998
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.5.1, 3.6.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.1, 3.6.0
>
>
> SpotBugs reports NP_NULL_ON_SOME_PATH_EXCEPTION in ResourceLocalizationService.PublicLocalizer.run(), where the
> ExecutionException handler dereferences assoc.
> The existing null check returns when assoc is null, but it is inside the same try block as completed.get(). 
> This causes SpotBugs to report a possible null dereference on the exception path.
> Move the null check before the inner try block so that assoc is explicitly non-null when entering both the download result handling
> and its exception handlers.
> This preserves the existing behavior, including logging and returning for an unknown resource. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org