You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/19 20:08:05 UTC
[GitHub] [solr] ackepenek opened a new pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
ackepenek opened a new pull request #753:
URL: https://github.com/apache/solr/pull/753
https://issues.apache.org/jira/browse/SOLR-16005
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Added "add field type" feature in to collection's schema screen.
# Solution
The button and functionality is added like add field.
# Tests
field type addition is tested manually.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
screenshot about improvement:
<img width="667" alt="image" src="https://user-images.githubusercontent.com/1234305/159136796-474beb21-42a0-4998-951e-f497b88fed4b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ackepenek commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
ackepenek commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1073860416
> Thanks @ackepenek, left a review. How would you like to be credited in the changelog???
Thanks for review. "Ahmet Can Kepenek" is good to be in changelog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1075277102
> @epugh while I appreciate the idea of robustness here for add/delete/modify, I also think we're losing some of the accessibility if we go that route. With the add field/dynamic field/copy field buttons, I don't have to know the syntax and the UI takes care of that for me. I think that's a really powerful motivation.
Could that concern be eased if there was a template dropdown with three choices "Add field type template", "Delete field type template" and "Replace field type template"? The template JSON would be filled in the text-area, and would be pre-filled with dummy values for the most common scenarios. There should also be a web link to ref-guide for easy reference of all the details.
It is far better to have such a UI than having nothing, and then a full-fledged builder UI may come later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1074006014
> If you are ok to manage the add, delete, replace operations with single text area(json field). I can update the PR.
Go for it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1075247405
@epugh while I appreciate the idea of robustness here for add/delete/modify, I also think we're losing some of the accessibility if we go that route. With the add field/dynamic field/copy field buttons, I don't have to know the syntax and the UI takes care of that for me. I think that's a really powerful motivation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1073834692
Thanks @ackepenek, left a review. How would you like to be credited in the changelog???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1073863796
@ackepenek so I tried out the feature locally, and I really like it, but did have a thought.... Instead of this being a hard coded to the `add-field-type` command, what if instead it was an interface for you to paste your JSON commands? The use case that I was thinking about is that as I iterate on my relevance algorithem, I'll often modify the same field a couple of times as I figure out what I need, which means I either have a script that does a `delete-field-type` and then `add-field-type` or I used the `replace-field-type`, though honestly I mostly just Delete and Add!
What if the button said "Manipulate Field Type" and then it took any json, and ran it, so it assumes you pass in `add-field-type`, `replace-field-type` or `delete-field-type` as appropriate? That might make this feature a lot more robust all the way around, and avoid you having to add a "Delete" button?
Most people using this are probably crafting the JSON outside anyway.
Also, if this button works well here, I wonder if something like it should be added to the Schema Designer?
THoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ackepenek commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
ackepenek commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1074002756
> @ackepenek so I tried out the feature locally, and I really like it, but did have a thought.... Instead of this being a hard coded to the `add-field-type` command, what if instead it was an interface for you to paste your JSON commands? The use case that I was thinking about is that as I iterate on my relevance algorithem, I'll often modify the same field a couple of times as I figure out what I need, which means I either have a script that does a `delete-field-type` and then `add-field-type` or I used the `replace-field-type`, though honestly I mostly just Delete and Add!
>
> What if the button said "Manipulate Field Type" and then it took any json, and ran it, so it assumes you pass in `add-field-type`, `replace-field-type` or `delete-field-type` as appropriate? That might make this feature a lot more robust all the way around, and avoid you having to add a "Delete" button?
>
> Most people using this are probably crafting the JSON outside anyway.
>
@epugh thanks for comments. If we manage the field types with single button that called "Manipulate Field Type" the textarea can take the json which contains the commands that names are add-field-type, delete-field-type, replace-field-type).
And the button manipulates the process that we specified in the json.
If you are ok to manage the add, delete, replace operations with single text area(json field). I can update the PR.
> Also, if this button works well here, I wonder if something like it should be added to the Schema Designer?
>
hmm. why not. but I am not sure that we should think it with this issue. I am open your ideas about screens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ackepenek commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
ackepenek commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1074055002
I improved the PR by comments.
latest screenshot:
<img width="567" alt="image" src="https://user-images.githubusercontent.com/1234305/159296658-479d6afc-c14a-4ca8-b434-3a1a054c2884.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1075441419
Thank you for looking @madrob and @janhoy... So the first version that @ackepenek had was basically the "Add field type Template". You just put in the JSON, without the `add-field-template` command. My gut feeling is that this is a tool that people coming from using Postman or other JSON syntax native tools, who don't want to figure out how to craft the perfect URL, would benefit from. Those people would already have the command in it...
This does make me wonder, is the real utility of this screen that you can take your JSON commands and just paste them in and run them wihtout crafting the URL, or figuring out any security etc because you are in the admin tool?
Maybe what we really want is to support what https://solr.apache.org/guide/8_11/schema-api.html#multiple-commands-in-a-single-post suggests. What if this was the "Scripted Schema Modifications"? We reference the schema api docs, and you can mix up your various commands, `add-field-type`, `add-field`, `delete-field` etc? They all go through the same `Schema.post` command anyway, right?
This would let me take my `setup-experiment-schema.json` file that i already might have, and not have to worry about postman etc, just cut n paste right into solr. It also would be more clearly not a "Here is the simple accessible UI"...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] ackepenek commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type
Posted by GitBox <gi...@apache.org>.
ackepenek commented on pull request #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1078775395
@madrob @janhoy @epugh
I am agree with @epugh. We should get better all admin panel to understand what we can do. We should put info text to panel where we need. I think it is makes more sense to do analyze to improve admin panel usage.
We just give a capability to manipulate the field type. It's better than zero capability. I think this development is simple and useful.
do we have any concerns still? or any requests? I am open any ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org