You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/12/22 02:51:14 UTC

[GitHub] [skywalking] wankai123 commented on a diff in pull request #10192: The cluster coordinator support watch mechanism for notifying `RemoteClientManager` and `ServerStatusService`.

wankai123 commented on code in PR #10192:
URL: https://github.com/apache/skywalking/pull/10192#discussion_r1055038441


##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java:
##########
@@ -355,18 +355,20 @@ public void start() throws ModuleStartException {
 
         Address gRPCServerInstanceAddress = new Address(moduleConfig.getGRPCHost(), moduleConfig.getGRPCPort(), true);
         TelemetryRelatedContext.INSTANCE.setId(gRPCServerInstanceAddress.toString());
+        ClusterCoordinator coordinator = this.getManager()
+                                             .find(ClusterModule.NAME)
+                                             .provider()
+                                             .getService(ClusterCoordinator.class);
+        coordinator.startCoordinator();
+        coordinator.registerWatcher(remoteClientManager);

Review Comment:
   Not necessary, but do register first more clearly. I'll fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org