[GitHub] [incubator-pegasus] acelyc111 commented on a change in pull request #732: feat(hotspot): add a cluster level perf_counter to display hotspot

[GitBox <gi...@apache.org>]

acelyc111 commented on a change in pull request #732:
URL: https://github.com/apache/incubator-pegasus/pull/732#discussion_r637418182



##########
File path: src/server/hotspot_partition_calculator.cpp
##########
@@ -136,7 +150,8 @@ void hotspot_partition_calculator::data_analyse()
             "The number of partitions in this table has changed, and hotspot analysis cannot be "
             "performed,in %s",
             _app_name.c_str());
-    for (int data_type = 0; data_type <= 1; data_type++) {
+
+    for (uint32_t data_type = 0; data_type <= 1; data_type++) {

Review comment:
       `1` is a magic number here, you can define an enum `HOTSPOT_DATA_TYPE_MAX` and use it here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org