You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "TaiJuWu (via GitHub)" <gi...@apache.org> on 2026/01/17 01:31:24 UTC
[PR] MINOR: add auto join behavior to admin RemoveRaftVoter java doc [kafka]
TaiJuWu opened a new pull request, #21322:
URL: https://github.com/apache/kafka/pull/21322
MINOR: add auto join behavior to admin RemoveRaftVoter java doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add auto join behavior to admin RemoveRaftVoter java doc [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #21322:
URL: https://github.com/apache/kafka/pull/21322#discussion_r2701269357
##########
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##########
@@ -1891,6 +1891,10 @@ AddRaftVoterResult addRaftVoter(
/**
* Remove a voter node from the KRaft metadata quorum.
*
+ * <p> If {@code controller.quorum.auto.join.enable} is set to true the controller
Review Comment:
Would you mind adding `Note: Since 4.2.0,`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Added a @since 4.2.0 note to removeRaftVoter in Admin.java explaining the interaction with controller.quorum.auto.join.enable [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #21322:
URL: https://github.com/apache/kafka/pull/21322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: add auto join behavior to admin RemoveRaftVoter java doc [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #21322:
URL: https://github.com/apache/kafka/pull/21322#discussion_r2705251508
##########
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##########
@@ -1891,6 +1891,10 @@ AddRaftVoterResult addRaftVoter(
/**
* Remove a voter node from the KRaft metadata quorum.
*
+ * <p> Note: Since 4.2.0, If {@code controller.quorum.auto.join.enable} is set to true the controller
Review Comment:
Could you move this block to the variant?
```
RemoveRaftVoterResult removeRaftVoter(
int voterId,
Uuid voterDirectoryId,
RemoveRaftVoterOptions options
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org