You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/11 04:51:18 UTC
[jira] [Commented] (GEODE-2622) Fix failures in
GMSMembershipManagerJUnitTest caused by upgrading to mockito 2.7.11
[ https://issues.apache.org/jira/browse/GEODE-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045813#comment-16045813 ]
ASF GitHub Bot commented on GEODE-2622:
---------------------------------------
GitHub user smanvi-pivotal opened a pull request:
https://github.com/apache/geode/pull/573
GEODE-2622: Fix test failures caused by upgrade to Mockito 2.7.11
- Fix 4 test failures in GMSMembershipManagerJUnitTest
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smanvi-pivotal/geode feature/GEODE-2622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #573
----
commit d3dca7ce2df5dca12a4f82a0e4289c5106c0a6c9
Author: Srikanth Manvi <sr...@gmail.com>
Date: 2017-06-11T04:40:57Z
GEODE-2622: Fix test failures caused by upgrade to Mockito 2.7.11
- Fix 4 test failures in GMSMembershipManagerJUnitTest
----
> Fix failures in GMSMembershipManagerJUnitTest caused by upgrading to mockito 2.7.11
> -----------------------------------------------------------------------------------
>
> Key: GEODE-2622
> URL: https://issues.apache.org/jira/browse/GEODE-2622
> Project: Geode
> Issue Type: Sub-task
> Components: tests
> Reporter: Kirk Lund
> Assignee: Srikanth Manvi
>
> These tests fail on branch feature/GEODE-2558:
> * GMSMembershipManagerJUnitTest.testDirectChannelSend
> * GMSMembershipManagerJUnitTest.testDirectChannelSendAllRecipients
> * GMSMembershipManagerJUnitTest.testDirectChannelSendFailureDueToForcedDisconnect
> * GMSMembershipManagerJUnitTest.testDirectChannelSendFailureToOneRecipient
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)