You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2022/04/19 21:31:14 UTC
[datasketches-java] 01/01: Made the public heapify method throw if the given memory is in updatable format.
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch disallowUpdatableHeapify
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit 3f146ee42e4698a503e61b06ce23ee5712ea14ec
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Tue Apr 19 14:30:47 2022 -0700
Made the public heapify method throw if the given memory is in updatable
format.
---
.../java/org/apache/datasketches/kll/KllDoublesSketch.java | 8 ++++----
.../java/org/apache/datasketches/kll/KllFloatsSketch.java | 8 ++++----
.../org/apache/datasketches/kll/KllHeapDoublesSketch.java | 14 ++++++++++++--
.../org/apache/datasketches/kll/KllHeapFloatsSketch.java | 14 ++++++++++++--
src/main/java/org/apache/datasketches/kll/KllSketch.java | 3 ++-
.../datasketches/kll/KllDirectDoublesSketchTest.java | 4 ++--
.../apache/datasketches/kll/KllDirectFloatsSketchTest.java | 4 ++--
.../org/apache/datasketches/kll/MiscDirectDoublesTest.java | 6 +++---
.../org/apache/datasketches/kll/MiscDirectFloatsTest.java | 6 +++---
.../java/org/apache/datasketches/kll/MiscDoublesTest.java | 12 ++++++------
.../java/org/apache/datasketches/kll/MiscFloatsTest.java | 12 ++++++------
11 files changed, 56 insertions(+), 35 deletions(-)
diff --git a/src/main/java/org/apache/datasketches/kll/KllDoublesSketch.java b/src/main/java/org/apache/datasketches/kll/KllDoublesSketch.java
index b5162498..6ef6a172 100644
--- a/src/main/java/org/apache/datasketches/kll/KllDoublesSketch.java
+++ b/src/main/java/org/apache/datasketches/kll/KllDoublesSketch.java
@@ -21,8 +21,9 @@ package org.apache.datasketches.kll;
import static java.lang.Math.max;
import static java.lang.Math.min;
+import static org.apache.datasketches.kll.KllPreambleUtil.getMemoryUpdatableFormatFlag;
+import static org.apache.datasketches.kll.KllSketch.Error.MUST_NOT_BE_UPDATABLE_FORMAT;
import static org.apache.datasketches.kll.KllSketch.Error.MUST_NOT_CALL;
-import static org.apache.datasketches.kll.KllSketch.Error.SRC_MUST_BE_DOUBLE;
import static org.apache.datasketches.kll.KllSketch.Error.TGT_IS_READ_ONLY;
import static org.apache.datasketches.kll.KllSketch.Error.kllSketchThrow;
@@ -58,9 +59,8 @@ public abstract class KllDoublesSketch extends KllSketch {
*/
public static KllDoublesSketch heapify(final Memory srcMem) {
Objects.requireNonNull(srcMem, "Parameter 'srcMem' must not be null");
- final KllMemoryValidate memVal = new KllMemoryValidate(srcMem);
- if (!memVal.doublesSketch) { Error.kllSketchThrow(SRC_MUST_BE_DOUBLE); }
- return new KllHeapDoublesSketch(srcMem, memVal);
+ if (getMemoryUpdatableFormatFlag(srcMem)) { Error.kllSketchThrow(MUST_NOT_BE_UPDATABLE_FORMAT); }
+ return KllHeapDoublesSketch.heapifyImpl(srcMem);
}
/**
diff --git a/src/main/java/org/apache/datasketches/kll/KllFloatsSketch.java b/src/main/java/org/apache/datasketches/kll/KllFloatsSketch.java
index 17275d42..7f0b0f10 100644
--- a/src/main/java/org/apache/datasketches/kll/KllFloatsSketch.java
+++ b/src/main/java/org/apache/datasketches/kll/KllFloatsSketch.java
@@ -21,8 +21,9 @@ package org.apache.datasketches.kll;
import static java.lang.Math.max;
import static java.lang.Math.min;
+import static org.apache.datasketches.kll.KllPreambleUtil.getMemoryUpdatableFormatFlag;
+import static org.apache.datasketches.kll.KllSketch.Error.MUST_NOT_BE_UPDATABLE_FORMAT;
import static org.apache.datasketches.kll.KllSketch.Error.MUST_NOT_CALL;
-import static org.apache.datasketches.kll.KllSketch.Error.SRC_MUST_BE_FLOAT;
import static org.apache.datasketches.kll.KllSketch.Error.TGT_IS_READ_ONLY;
import static org.apache.datasketches.kll.KllSketch.Error.kllSketchThrow;
@@ -58,9 +59,8 @@ public abstract class KllFloatsSketch extends KllSketch {
*/
public static KllFloatsSketch heapify(final Memory srcMem) {
Objects.requireNonNull(srcMem, "Parameter 'srcMem' must not be null");
- final KllMemoryValidate memVal = new KllMemoryValidate(srcMem);
- if (memVal.doublesSketch) { Error.kllSketchThrow(SRC_MUST_BE_FLOAT); }
- return new KllHeapFloatsSketch(srcMem, memVal);
+ if (getMemoryUpdatableFormatFlag(srcMem)) { Error.kllSketchThrow(MUST_NOT_BE_UPDATABLE_FORMAT); }
+ return KllHeapFloatsSketch.heapifyImpl(srcMem);
}
/**
diff --git a/src/main/java/org/apache/datasketches/kll/KllHeapDoublesSketch.java b/src/main/java/org/apache/datasketches/kll/KllHeapDoublesSketch.java
index 7383ddf3..189b9560 100644
--- a/src/main/java/org/apache/datasketches/kll/KllHeapDoublesSketch.java
+++ b/src/main/java/org/apache/datasketches/kll/KllHeapDoublesSketch.java
@@ -23,8 +23,11 @@ import static org.apache.datasketches.kll.KllPreambleUtil.DATA_START_ADR;
import static org.apache.datasketches.kll.KllPreambleUtil.DATA_START_ADR_SINGLE_ITEM;
import static org.apache.datasketches.kll.KllSketch.Error.MUST_NOT_CALL;
import static org.apache.datasketches.kll.KllSketch.Error.NOT_SINGLE_ITEM;
+import static org.apache.datasketches.kll.KllSketch.Error.SRC_MUST_BE_DOUBLE;
import static org.apache.datasketches.kll.KllSketch.Error.kllSketchThrow;
+import java.util.Objects;
+
import org.apache.datasketches.memory.Memory;
/**
@@ -74,9 +77,9 @@ final class KllHeapDoublesSketch extends KllDoublesSketch {
/**
* Heapify constructor.
* @param srcMem Memory object that contains data serialized by this sketch.
- * @param memVal the MemoryCheck object
+ * @param memVal the MemoryVaidate object
*/
- KllHeapDoublesSketch(final Memory srcMem, final KllMemoryValidate memVal) {
+ private KllHeapDoublesSketch(final Memory srcMem, final KllMemoryValidate memVal) {
super(null, null );
k_ = memVal.k;
m_ = memVal.m;
@@ -117,6 +120,13 @@ final class KllHeapDoublesSketch extends KllDoublesSketch {
}
}
+ static KllHeapDoublesSketch heapifyImpl(final Memory srcMem) {
+ Objects.requireNonNull(srcMem, "Parameter 'srcMem' must not be null");
+ final KllMemoryValidate memVal = new KllMemoryValidate(srcMem);
+ if (!memVal.doublesSketch) { Error.kllSketchThrow(SRC_MUST_BE_DOUBLE); }
+ return new KllHeapDoublesSketch(srcMem, memVal);
+ }
+
@Override
public int getK() { return k_; }
diff --git a/src/main/java/org/apache/datasketches/kll/KllHeapFloatsSketch.java b/src/main/java/org/apache/datasketches/kll/KllHeapFloatsSketch.java
index 32c331bd..3499850e 100644
--- a/src/main/java/org/apache/datasketches/kll/KllHeapFloatsSketch.java
+++ b/src/main/java/org/apache/datasketches/kll/KllHeapFloatsSketch.java
@@ -23,8 +23,11 @@ import static org.apache.datasketches.kll.KllPreambleUtil.DATA_START_ADR;
import static org.apache.datasketches.kll.KllPreambleUtil.DATA_START_ADR_SINGLE_ITEM;
import static org.apache.datasketches.kll.KllSketch.Error.MUST_NOT_CALL;
import static org.apache.datasketches.kll.KllSketch.Error.NOT_SINGLE_ITEM;
+import static org.apache.datasketches.kll.KllSketch.Error.SRC_MUST_BE_FLOAT;
import static org.apache.datasketches.kll.KllSketch.Error.kllSketchThrow;
+import java.util.Objects;
+
import org.apache.datasketches.memory.Memory;
/**
@@ -74,9 +77,9 @@ final class KllHeapFloatsSketch extends KllFloatsSketch {
/**
* Heapify constructor.
* @param srcMem Memory object that contains data serialized by this sketch.
- * @param memVal the MemoryCheck object
+ * @param memVal the MemoryValidate object
*/
- KllHeapFloatsSketch(final Memory srcMem, final KllMemoryValidate memVal) {
+ private KllHeapFloatsSketch(final Memory srcMem, final KllMemoryValidate memVal) {
super(null, null);
k_ = memVal.k;
m_ = memVal.m;
@@ -117,6 +120,13 @@ final class KllHeapFloatsSketch extends KllFloatsSketch {
}
}
+ static KllHeapFloatsSketch heapifyImpl(final Memory srcMem) {
+ Objects.requireNonNull(srcMem, "Parameter 'srcMem' must not be null");
+ final KllMemoryValidate memVal = new KllMemoryValidate(srcMem);
+ if (memVal.doublesSketch) { Error.kllSketchThrow(SRC_MUST_BE_FLOAT); }
+ return new KllHeapFloatsSketch(srcMem, memVal);
+ }
+
@Override
public int getK() { return k_; }
diff --git a/src/main/java/org/apache/datasketches/kll/KllSketch.java b/src/main/java/org/apache/datasketches/kll/KllSketch.java
index e7162348..d2d16bc8 100644
--- a/src/main/java/org/apache/datasketches/kll/KllSketch.java
+++ b/src/main/java/org/apache/datasketches/kll/KllSketch.java
@@ -81,7 +81,8 @@ abstract class KllSketch {
MUST_NOT_CALL("This is an artifact of inheritance and should never be called."),
SINGLE_ITEM_IMPROPER_CALL("Improper method use for single-item sketch"),
MRS_MUST_NOT_BE_NULL("MemoryRequestServer cannot be null."),
- NOT_SINGLE_ITEM("Sketch is not single item.");
+ NOT_SINGLE_ITEM("Sketch is not single item."),
+ MUST_NOT_BE_UPDATABLE_FORMAT("Given Memory object must not be in updatableFormat.");
private String msg;
diff --git a/src/test/java/org/apache/datasketches/kll/KllDirectDoublesSketchTest.java b/src/test/java/org/apache/datasketches/kll/KllDirectDoublesSketchTest.java
index 599368d6..d43751e0 100644
--- a/src/test/java/org/apache/datasketches/kll/KllDirectDoublesSketchTest.java
+++ b/src/test/java/org/apache/datasketches/kll/KllDirectDoublesSketchTest.java
@@ -550,7 +550,7 @@ public class KllDirectDoublesSketchTest {
assertFalse(sketch.isFloatsSketch());
final WritableMemory wmem = sketch.getWritableMemory();
- final KllDoublesSketch sk = KllDoublesSketch.heapify(wmem);
+ final KllDoublesSketch sk = KllHeapDoublesSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), 200);
assertEquals(sk.getN(), 200);
assertFalse(sk.isEmpty());
@@ -584,7 +584,7 @@ public class KllDirectDoublesSketchTest {
WritableMemory dstMem = WritableMemory.allocate(6000);
KllDoublesSketch sk = KllDoublesSketch.newDirectInstance(20, dstMem, memReqSvr);
for (int i = 1; i <= 100; i++) { sk.update(i); }
- KllDoublesSketch sk2 = KllDoublesSketch.heapify(dstMem);
+ KllDoublesSketch sk2 = KllHeapDoublesSketch.heapifyImpl(dstMem);
assertEquals(sk2.getMinValue(), 1.0);
assertEquals(sk2.getMaxValue(), 100.0);
}
diff --git a/src/test/java/org/apache/datasketches/kll/KllDirectFloatsSketchTest.java b/src/test/java/org/apache/datasketches/kll/KllDirectFloatsSketchTest.java
index 2e202f3a..a159dc54 100644
--- a/src/test/java/org/apache/datasketches/kll/KllDirectFloatsSketchTest.java
+++ b/src/test/java/org/apache/datasketches/kll/KllDirectFloatsSketchTest.java
@@ -550,7 +550,7 @@ public class KllDirectFloatsSketchTest {
assertFalse(sketch.isDoublesSketch());
final WritableMemory wmem = sketch.getWritableMemory();
- final KllFloatsSketch sk = KllFloatsSketch.heapify(wmem);
+ final KllFloatsSketch sk = KllHeapFloatsSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), 200);
assertEquals(sk.getN(), 200);
assertFalse(sk.isEmpty());
@@ -584,7 +584,7 @@ public class KllDirectFloatsSketchTest {
WritableMemory dstMem = WritableMemory.allocate(6000);
KllFloatsSketch sk = KllFloatsSketch.newDirectInstance(20, dstMem, memReqSvr);
for (int i = 1; i <= 100; i++) { sk.update(i); }
- KllFloatsSketch sk2 = KllFloatsSketch.heapify(dstMem);
+ KllFloatsSketch sk2 = KllHeapFloatsSketch.heapifyImpl(dstMem);
assertEquals(sk2.getMinValue(), 1.0);
assertEquals(sk2.getMaxValue(), 100.0);
}
diff --git a/src/test/java/org/apache/datasketches/kll/MiscDirectDoublesTest.java b/src/test/java/org/apache/datasketches/kll/MiscDirectDoublesTest.java
index 15337ad7..84f5f37b 100644
--- a/src/test/java/org/apache/datasketches/kll/MiscDirectDoublesTest.java
+++ b/src/test/java/org/apache/datasketches/kll/MiscDirectDoublesTest.java
@@ -245,7 +245,7 @@ public class MiscDirectDoublesTest {
//println(sk2.toString(true, true));
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
- sk = KllDoublesSketch.heapify(wmem);
+ sk = KllHeapDoublesSketch.heapifyImpl(wmem);
println(sk.toString(true, true));
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), k + 1);
@@ -266,7 +266,7 @@ public class MiscDirectDoublesTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
//println(KllPreambleUtil.toString(wmem));
- sk = KllDoublesSketch.heapify(wmem);
+ sk = KllHeapDoublesSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), 0);
assertEquals(sk.getNumRetained(), 0);
@@ -287,7 +287,7 @@ public class MiscDirectDoublesTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
//println(KllPreambleUtil.memoryToString(wmem, true));
- sk = KllDoublesSketch.heapify(wmem);
+ sk = KllHeapDoublesSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), 1);
assertEquals(sk.getNumRetained(), 1);
diff --git a/src/test/java/org/apache/datasketches/kll/MiscDirectFloatsTest.java b/src/test/java/org/apache/datasketches/kll/MiscDirectFloatsTest.java
index b8a9aadc..6810dc2d 100644
--- a/src/test/java/org/apache/datasketches/kll/MiscDirectFloatsTest.java
+++ b/src/test/java/org/apache/datasketches/kll/MiscDirectFloatsTest.java
@@ -246,7 +246,7 @@ public class MiscDirectFloatsTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
//println(KllPreambleUtil.toString(wmem));
- sk = KllFloatsSketch.heapify(wmem);
+ sk = KllHeapFloatsSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), k + 1);
assertEquals(sk.getNumRetained(), 11);
@@ -266,7 +266,7 @@ public class MiscDirectFloatsTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
//println(KllPreambleUtil.toString(wmem));
- sk = KllFloatsSketch.heapify(wmem);
+ sk = KllHeapFloatsSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), 0);
assertEquals(sk.getNumRetained(), 0);
@@ -287,7 +287,7 @@ public class MiscDirectFloatsTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
//println(KllPreambleUtil.toString(wmem));
- sk = KllFloatsSketch.heapify(wmem);
+ sk = KllHeapFloatsSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), 1);
assertEquals(sk.getNumRetained(), 1);
diff --git a/src/test/java/org/apache/datasketches/kll/MiscDoublesTest.java b/src/test/java/org/apache/datasketches/kll/MiscDoublesTest.java
index d2711411..e86488aa 100644
--- a/src/test/java/org/apache/datasketches/kll/MiscDoublesTest.java
+++ b/src/test/java/org/apache/datasketches/kll/MiscDoublesTest.java
@@ -305,7 +305,7 @@ public class MiscDoublesTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
println(KllPreambleUtil.toString(wmem, true));
- sk = KllDoublesSketch.heapify(wmem);
+ sk = KllHeapDoublesSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), k + 1);
assertEquals(sk.getNumRetained(), 11);
@@ -325,7 +325,7 @@ public class MiscDoublesTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
println(KllPreambleUtil.toString(wmem, true));
- sk = KllDoublesSketch.heapify(wmem);
+ sk = KllHeapDoublesSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), 0);
assertEquals(sk.getNumRetained(), 0);
@@ -346,7 +346,7 @@ public class MiscDoublesTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
println(KllPreambleUtil.toString(wmem, true));
- sk = KllDoublesSketch.heapify(wmem);
+ sk = KllHeapDoublesSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), 1);
assertEquals(sk.getNumRetained(), 1);
@@ -437,7 +437,7 @@ public class MiscDoublesTest {
s = KllPreambleUtil.toString(wmem, true);
println("step 1: sketch to byte[]/memory & analyze memory");
println(s);
- sk2 = KllDoublesSketch.heapify(wmem);
+ sk2 = KllHeapDoublesSketch.heapifyImpl(wmem);
upBytes2 = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(upBytes2);
s = KllPreambleUtil.toString(wmem, true);
@@ -455,7 +455,7 @@ public class MiscDoublesTest {
s = KllPreambleUtil.toString(wmem, true);
println("step 1: sketch to byte[]/memory & analyze memory");
println(s);
- sk2 = KllDoublesSketch.heapify(wmem);
+ sk2 = KllHeapDoublesSketch.heapifyImpl(wmem);
upBytes2 = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(upBytes2);
s = KllPreambleUtil.toString(wmem, true);
@@ -471,7 +471,7 @@ public class MiscDoublesTest {
s = KllPreambleUtil.toString(wmem, true);
println("step 1: sketch to byte[]/memory & analyze memory");
println(s);
- sk2 = KllDoublesSketch.heapify(wmem);
+ sk2 = KllHeapDoublesSketch.heapifyImpl(wmem);
upBytes2 = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(upBytes2);
s = KllPreambleUtil.toString(wmem, true);
diff --git a/src/test/java/org/apache/datasketches/kll/MiscFloatsTest.java b/src/test/java/org/apache/datasketches/kll/MiscFloatsTest.java
index 406e98c3..57cc244a 100644
--- a/src/test/java/org/apache/datasketches/kll/MiscFloatsTest.java
+++ b/src/test/java/org/apache/datasketches/kll/MiscFloatsTest.java
@@ -305,7 +305,7 @@ public class MiscFloatsTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
println(KllPreambleUtil.toString(wmem, true));
- sk = KllFloatsSketch.heapify(wmem);
+ sk = KllHeapFloatsSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), k + 1);
assertEquals(sk.getNumRetained(), 11);
@@ -325,7 +325,7 @@ public class MiscFloatsTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
println(KllPreambleUtil.toString(wmem, true));
- sk = KllFloatsSketch.heapify(wmem);
+ sk = KllHeapFloatsSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), 0);
assertEquals(sk.getNumRetained(), 0);
@@ -346,7 +346,7 @@ public class MiscFloatsTest {
compBytes = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(compBytes);
println(KllPreambleUtil.toString(wmem, true));
- sk = KllFloatsSketch.heapify(wmem);
+ sk = KllHeapFloatsSketch.heapifyImpl(wmem);
assertEquals(sk.getK(), k);
assertEquals(sk.getN(), 1);
assertEquals(sk.getNumRetained(), 1);
@@ -437,7 +437,7 @@ public class MiscFloatsTest {
s = KllPreambleUtil.toString(wmem, true);
println("step 1: sketch to byte[]/memory & analyze memory");
println(s);
- sk2 = KllFloatsSketch.heapify(wmem);
+ sk2 = KllHeapFloatsSketch.heapifyImpl(wmem);
upBytes2 = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(upBytes2);
s = KllPreambleUtil.toString(wmem, true);
@@ -455,7 +455,7 @@ public class MiscFloatsTest {
s = KllPreambleUtil.toString(wmem, true);
println("step 1: sketch to byte[]/memory & analyze memory");
println(s);
- sk2 = KllFloatsSketch.heapify(wmem);
+ sk2 = KllHeapFloatsSketch.heapifyImpl(wmem);
upBytes2 = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(upBytes2);
s = KllPreambleUtil.toString(wmem, true);
@@ -471,7 +471,7 @@ public class MiscFloatsTest {
s = KllPreambleUtil.toString(wmem, true);
println("step 1: sketch to byte[]/memory & analyze memory");
println(s);
- sk2 = KllFloatsSketch.heapify(wmem);
+ sk2 = KllHeapFloatsSketch.heapifyImpl(wmem);
upBytes2 = KllHelper.toUpdatableByteArrayImpl(sk2);
wmem = WritableMemory.writableWrap(upBytes2);
s = KllPreambleUtil.toString(wmem, true);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org