You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "cakeni (via GitHub)" <gi...@apache.org> on 2026/08/11 11:42:57 UTC
[PR] Replace concat_elements_utf8_many BufferBuilders with Vec [arrow-rs]
cakeni opened a new pull request, #10633:
URL: https://github.com/apache/arrow-rs/pull/10633
# Which issue does this PR close?
- Part of #10245.
# Rationale for this change
Using `Vec` instead of `BufferBuilder` can benefit from Rust's optimized vector implementation. This updates the value and offset builders in `concat_elements_utf8_many`.
# What changes are included in this PR?
- Replace the many-array output value and offset builders with capacity-matched vectors.
- Use `extend_from_slice` and `push` while preserving the existing offset iteration.
- Convert the vectors directly into the buffers used by `ArrayDataBuilder`.
- Leave the separate two-array concatenation path unchanged.
# Are these changes tested?
Yes. The following checks pass:
- `cargo +stable-x86_64-pc-windows-gnu fmt --all -- --check`
- `cargo +stable-x86_64-pc-windows-gnu clippy -p arrow-string --all-targets --all-features --no-deps -- -D warnings`
- `cargo +stable-x86_64-pc-windows-gnu test -p arrow-string --all-features` (182 unit tests and 10 doctests passed)
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Replace concat_elements_utf8_many BufferBuilders with Vec [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #10633:
URL: https://github.com/apache/arrow-rs/pull/10633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org