[GitHub] jvrao commented on a change in pull request #1572: Use readExplicitLAC instead of readEntry in order to get current LastAddConfirmed

[GitBox <gi...@apache.org>]

jvrao commented on a change in pull request #1572: Use readExplicitLAC instead of readEntry in order to get current LastAddConfirmed
URL: https://github.com/apache/bookkeeper/pull/1572#discussion_r244428980
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
 ##########
 @@ -1335,6 +1335,14 @@ synchronized void updateLastConfirmed(long lac, long len) {
      */
 
     public void asyncReadLastConfirmed(final ReadLastConfirmedCallback cb, final Object ctx) {
+        if (clientCtx.getConf().useExplicitLacForReads) {
 
 Review comment:
   Client knows it is using V3 protocol or not; so why not use the explicitLAC for >= v3 automatically without a conf option?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services