You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/05 10:02:37 UTC

[GitHub] [arrow] rtpsw commented on a diff in pull request #15190: GH-15176: Fix various issues introduced in the asof-join benchmark by ARROW-17980 and ARROW-15732

rtpsw commented on code in PR #15190:
URL: https://github.com/apache/arrow/pull/15190#discussion_r1062300792


##########
cpp/src/arrow/compute/exec/asof_join_benchmark.cc:
##########
@@ -112,8 +115,8 @@ AsofJoinNodeOptions GetRepeatedOptions(size_t repeat, FieldRef on_key,
 
 static void AsOfJoinOverhead(benchmark::State& state) {
   int64_t tolerance = 0;
-  AsofJoinNodeOptions options =
-      GetRepeatedOptions(int(state.range(4)), kTimeCol, {kKeyCol}, tolerance);
+  auto options = std::make_shared<AsofJoinNodeOptions>(
+      GetRepeatedOptions(int(state.range(4) + 1), kTimeCol, {kKeyCol}, tolerance));

Review Comment:
   Sorry, I somehow missed this. The fix seems right to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org